fix(input,select): set disabled underline color based on theme #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
May 30, 2017
crisbeto
commented
- Fixes the disabled underline blending in with the background in dark themes.
- Increases the opacity of the disabled underline from 26% to 38% to make a bit more visible against the background.
* Fixes the disabled underline blending in with the background in dark themes. * Increases the opacity of the disabled underline from 26% to 38% to make a bit more visible against the background.
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 15, 2017
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states). * Includes the changes from angular#4883 since the two PRs are closely connected. Fixes angular#5114.
Member
Author
|
I've rolled these changes into #5155. Closing. |
mmalerba
pushed a commit
that referenced
this pull request
Jul 6, 2017
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states). * Includes the changes from #4883 since the two PRs are closely connected. Fixes #5114.
jelbourn
pushed a commit
that referenced
this pull request
Jul 14, 2017
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states). * Includes the changes from #4883 since the two PRs are closely connected. Fixes #5114.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 15, 2017
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states). * Includes the changes from angular#4883 since the two PRs are closely connected. Fixes angular#5114.
kara
pushed a commit
that referenced
this pull request
Jul 21, 2017
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states). * Includes the changes from #4883 since the two PRs are closely connected. Fixes #5114.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.