fix(input): single-line hints overflowing the parent #4107
Conversation
Fixes the input container hints causing an overflow on the parent by a couple of pixels. Note that this can be fixed alternatively by setting `line-height: 1` on the wrapper, however it causes multi-line hints to be a little too compact. I went with 1.2 since it seems to be the closest to the browser defaults for `normal`. Fixes angular#4051.
googlebot
added
the
cla: yes
| width: 100%; | ||
| margin-top: -$mat-input-wrapper-spacing; | ||
| margin-top: -$line-height; | ||
| line-height: $line-height; |
There was a problem hiding this comment.
why not change the line-height on .mat-input-container from normal to 1.2em instead of overriding here?
There was a problem hiding this comment.
I wanted to avoid breaking other parts of the input container since these changes are only relevant to the hints.
There was a problem hiding this comment.
I think it should be ok, most browsers have normal = 1.2. Using 1.2 explicitly will make sure its consistent in all browsers
There was a problem hiding this comment.
Since changing the one on the container causes other elements to overflow I'm fine with doing this
src/lib/input/input-container.scss
Outdated
| // cannot apply it to the host element directly. | ||
| .mat-input-wrapper { | ||
| margin: $mat-input-wrapper-spacing 0; | ||
| margin: 1em 0; |
There was a problem hiding this comment.
why did you remove the constant?
There was a problem hiding this comment.
After the changes I did below, it was only being used in one place which makes it pointless.
There was a problem hiding this comment.
I think we often prefer constants even if they're only used once since they describe what the value is supposed to represent.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Fixes the input container hints causing an overflow on the parent by a couple of pixels. Note that this can be fixed alternatively by setting
line-height: 1on the wrapper, however it causes multi-line hints to be a little too compact. I went with 1.2 since it seems to be the closest to the browser defaults fornormal.Fixes #4051.