Skip to content

[JetSurvey] Improve sign up process #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2022
Merged

[JetSurvey] Improve sign up process #851

merged 3 commits into from
Jul 15, 2022

Conversation

tsuharesu
Copy link
Contributor

  • Handle configuration changes for text fields
  • Don't submit until data is valid
  • Add keyboard type to fields

This also includes changes similar to #529, so that PR can be closed when this is merged.

cc @alexvanyo

@tsuharesu tsuharesu requested a review from a team as a code owner June 17, 2022 14:20
@tsuharesu tsuharesu requested a review from astamato June 17, 2022 14:20
@astamato astamato requested a review from IanGClifton July 1, 2022 13:15
@astamato
Copy link
Contributor

astamato commented Jul 1, 2022 •
edited
Loading

Consider not storing unencrypted passwords as a best practice.
the rest LGTM, provided @IanGClifton agrees. Also ideally I'd try to use TextFieldValue but that requires a bigger refactor it seems.

@tsuharesu
Copy link
Contributor Author

Thanks @astamato. I changed the password bit.

IanGClifton
IanGClifton approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@IanGClifton IanGClifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements!

@astamato astamato merged commit 44421ce into android:main Jul 15, 2022
@tsuharesu tsuharesu deleted the improve_sign_up branch July 15, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@IanGClifton IanGClifton IanGClifton approved these changes

@astamato astamato astamato approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsuharesu @astamato @IanGClifton