Skip to content

Conversation

ashar-7
Copy link

@ashar-7 ashar-7 commented May 15, 2021

  • Add keyboardType and singleLine to Text Fields (Fix for multiple lines being input through the keyboard)
  • Replace keyboard action onDone with onAny in case a different Ime Action is used (Fixes focus not moving from Email field to Password field on Next action)

@stale
Copy link

stale bot commented May 10, 2022

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label May 10, 2022
@riggaroo riggaroo requested a review from a team as a code owner May 12, 2022 15:22
@riggaroo riggaroo requested a review from arriolac May 12, 2022 15:22
@stale stale bot removed stale labels May 12, 2022
@IanGClifton IanGClifton self-requested a review May 13, 2022 23:14
Copy link
Contributor

@IanGClifton IanGClifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a question for the onDone -> onAny change but everything else looks good!

keyboardActions = KeyboardActions(
onDone = {
onAny = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd want to use onAny here because that means onImeAction will also be called when next or previous (which should move focus) are triggered. Is there a case where onDone isn't enough?

keyboardActions = KeyboardActions(
onDone = {
onAny = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same 'onAny' comment here.

@stale
Copy link

stale bot commented Jul 12, 2022

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label Jul 12, 2022
@stale stale bot closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants