-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Jetsurvey] Fix Email and Password TextFields #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a question for the onDone -> onAny change but everything else looks good!
keyboardActions = KeyboardActions( | ||
onDone = { | ||
onAny = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'd want to use onAny here because that means onImeAction will also be called when next or previous (which should move focus) are triggered. Is there a case where onDone isn't enough?
keyboardActions = KeyboardActions( | ||
onDone = { | ||
onAny = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same 'onAny' comment here.
This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions. |
keyboardType
andsingleLine
to Text Fields (Fix for multiple lines being input through the keyboard)onDone
withonAny
in case a different Ime Action is used (Fixes focus not moving from Email field to Password field on Next action)