Treat warnings as errors #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There were several improvements in #108. Could you please check if this problem still exists? And if so, update the pull request so that the conflicts are resolved. |
|
At least some of these will still apply. I didn't get to putting all of these changes in my build. I especially appreciate the makefile changes with separate builds for Python 2 and 3. |
Collaborator
|
@cocasema thanks for the pull request. Unfortuantely, it now conflicts after recent merges. Could you please resolve the current conflicts so that I can merge it? |
Contributor
Author
|
@pdp7 done |
Collaborator
|
Tested OK with:
|
Collaborator
|
Thanks @cocasema! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added '-Wall', '-Werror' to compiler flags and fixed compilation errors for python2 and python3.