Treat warnings as errors

Author: cocasema

Makefile

@@ -17,3 +17,16 @@ build:
 
 install: build
 	python setup.py install --force
+
+build2:
+	python2 setup.py build --force
+
+install2: build2
+	python2 setup.py install --force
+
+build3:
+	python3 setup.py build --force
+
+install3: build3
+	python3 setup.py install --force
+	

setup.py

@@ -18,6 +18,8 @@
 else:
     kernel41 = None
 
+CFLAGS = ['-Wall', '-Werror', '-Wno-format-security']
+
 classifiers = ['Development Status :: 3 - Alpha',
                'Operating System :: POSIX :: Linux',
                'License :: OSI Approved :: MIT License',
@@ -40,9 +42,9 @@
       classifiers      = classifiers,
       packages         = find_packages(),
       py_modules       = ['Adafruit_I2C'],
-      ext_modules      = [Extension('Adafruit_BBIO.GPIO', ['source/py_gpio.c', 'source/event_gpio.c', 'source/constants.c', 'source/common.c'], extra_compile_args=['-Wno-format-security'], define_macros=kernel41),
-                          Extension('Adafruit_BBIO.PWM', ['source/py_pwm.c', 'source/c_pwm.c', 'source/constants.c', 'source/common.c'], extra_compile_args=['-Wno-format-security'], define_macros=kernel41),
-                          Extension('Adafruit_BBIO.ADC', ['source/py_adc.c', 'source/c_adc.c', 'source/constants.c', 'source/common.c'], extra_compile_args=['-Wno-format-security'], define_macros=kernel41),
-                          Extension('Adafruit_BBIO.SPI', ['source/spimodule.c', 'source/constants.c', 'source/common.c'], extra_compile_args=['-Wno-format-security'], define_macros=kernel41),
-                          Extension('Adafruit_BBIO.UART', ['source/py_uart.c', 'source/c_uart.c', 'source/constants.c', 'source/common.c'], extra_compile_args=['-Wno-format-security'], define_macros=kernel41)] )
+      ext_modules      = [Extension('Adafruit_BBIO.GPIO', ['source/py_gpio.c', 'source/event_gpio.c', 'source/constants.c', 'source/common.c'], extra_compile_args=CFLAGS, define_macros=kernel41),
+                          Extension('Adafruit_BBIO.PWM', ['source/py_pwm.c', 'source/c_pwm.c', 'source/constants.c', 'source/common.c'], extra_compile_args=CFLAGS, define_macros=kernel41),
+                          Extension('Adafruit_BBIO.ADC', ['source/py_adc.c', 'source/c_adc.c', 'source/constants.c', 'source/common.c'], extra_compile_args=CFLAGS, define_macros=kernel41),
+                          Extension('Adafruit_BBIO.SPI', ['source/spimodule.c', 'source/constants.c', 'source/common.c'], extra_compile_args=CFLAGS, define_macros=kernel41),
+                          Extension('Adafruit_BBIO.UART', ['source/py_uart.c', 'source/c_uart.c', 'source/constants.c', 'source/common.c'], extra_compile_args=CFLAGS, define_macros=kernel41)] )
 

source/c_pwm.c

@@ -82,11 +82,11 @@ int pwm_set_frequency(const char *key, float freq) {
     unsigned long period_ns;
     struct pwm_exp *pwm;
 
-    if (freq <= 0.0)
+    if (freq <= 0.0) {
         return -1;
+    }
 
     pwm = lookup_exported_pwm(key);
-
     if (pwm == NULL) {
         return -1;
     }
@@ -97,7 +97,9 @@ int pwm_set_frequency(const char *key, float freq) {
         pwm->period_ns = period_ns;
 
         len = snprintf(buffer, sizeof(buffer), "%lu", period_ns);
-        write(pwm->period_fd, buffer, len);
+        if (write(pwm->period_fd, buffer, len) < 0) {
+        	return -1;
+        }
     }
 
     return 1;
@@ -109,13 +111,14 @@ int pwm_set_polarity(const char *key, int polarity) {
     struct pwm_exp *pwm;
 
     pwm = lookup_exported_pwm(key);
-
     if (pwm == NULL) {
         return -1;
     }
 
     len = snprintf(buffer, sizeof(buffer), "%d", polarity);
-    write(pwm->polarity_fd, buffer, len);
+    if (write(pwm->polarity_fd, buffer, len) < 0) {
+    	return -1;
+    }
 
     return 0;
 }
@@ -125,19 +128,21 @@ int pwm_set_duty_cycle(const char *key, float duty) {
     char buffer[20];
     struct pwm_exp *pwm;
 
-    if (duty < 0.0 || duty > 100.0)
+    if (duty < 0.0 || duty > 100.0) {
         return -1;
+    }
 
     pwm = lookup_exported_pwm(key);
-
     if (pwm == NULL) {
         return -1;
     }    
 
     pwm->duty = (unsigned long)(pwm->period_ns * (duty / 100.0));
 
     len = snprintf(buffer, sizeof(buffer), "%lu", pwm->duty);
-    write(pwm->duty_fd, buffer, len);
+    if (write(pwm->duty_fd, buffer, len) < 0) {
+    	return -1;
+    }
 
     return 0;
 }
@@ -158,7 +163,6 @@ int pwm_start(const char *key, float duty, float freq, int polarity)
     }
 
     snprintf(fragment, sizeof(fragment), "bone_pwm_%s", key);
-    
 
     if (!load_device_tree(fragment)) {
         //error enabling pin for pwm
@@ -176,10 +180,10 @@ int pwm_start(const char *key, float duty, float freq, int polarity)
     snprintf(duty_path, sizeof(duty_path), "%s/duty", pwm_test_path);
     snprintf(polarity_path, sizeof(polarity_path), "%s/polarity", pwm_test_path);
 
-    //add period and duty fd to pwm list    
-    if ((period_fd = open(period_path, O_RDWR)) < 0)
+    //add period and duty fd to pwm list
+    if ((period_fd = open(period_path, O_RDWR)) < 0) {
         return -1;
-
+    }
 
     if ((duty_fd = open(duty_path, O_RDWR)) < 0) {
         //error, close already opened period_fd.

source/common.c

@@ -37,7 +37,9 @@ SOFTWARE.
 
 #include <linux/version.h>
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)
-    #define BBBVERSION41
+#  ifndef BBBVERSION41
+#    define BBBVERSION41
+#  endif
 #endif
 
 int setup_error = 0;

source/event_gpio.c

@@ -84,8 +84,11 @@ int gpio_export(unsigned int gpio)
         return -1;
     }
     len = snprintf(str_gpio, sizeof(str_gpio), "%d", gpio);
-    write(fd, str_gpio, len);
+    int ret = write(fd, str_gpio, len);
     close(fd);
+    if (ret < 0) {
+    	return ret;
+    }
 
     // add to list
     new_gpio = malloc(sizeof(struct gpio_exp));
@@ -197,8 +200,11 @@ int gpio_unexport(unsigned int gpio)
         return -1;
 
     len = snprintf(str_gpio, sizeof(str_gpio), "%d", gpio);
-    write(fd, str_gpio, len);
+    int ret = write(fd, str_gpio, len);
     close(fd);
+    if (ret < 0) {
+    	return ret;
+    }
 
     // remove from list
     g = exported_gpios;
@@ -237,8 +243,12 @@ int gpio_set_direction(unsigned int gpio, unsigned int in_flag)
             strncpy(direction, "in", ARRAY_SIZE(direction) - 1);
         }
 
-        write(fd, direction, strlen(direction));
+        int ret = write(fd, direction, strlen(direction));
         close(fd);
+        if (ret < 0) {
+        	return ret;
+        }
+
         return 0;
 }
 
@@ -253,7 +263,10 @@ int gpio_get_direction(unsigned int gpio, unsigned int *value)
         return -1;
 
     lseek(fd, 0, SEEK_SET);
-    read(fd, &direction, sizeof(direction) - 1);
+    int ret = read(fd, &direction, sizeof(direction) - 1);
+    if (ret < 0) {
+    	return ret;
+    }
 
     if (strcmp(direction, "out") == 0) {
         *value = OUTPUT;
@@ -285,8 +298,12 @@ int gpio_set_value(unsigned int gpio, unsigned int value)
         strncpy(vstr, "0", ARRAY_SIZE(vstr) - 1);
     }
 
-    write(fd, vstr, strlen(vstr));
+    int ret = write(fd, vstr, strlen(vstr));
     close(fd);
+    if (ret < 0) {
+    	return ret;
+    }
+
     return 0;
 }
 
@@ -302,7 +319,10 @@ int gpio_get_value(unsigned int gpio, unsigned int *value)
     }    
 
     lseek(fd, 0, SEEK_SET);
-    read(fd, &ch, sizeof(ch));
+    int ret = read(fd, &ch, sizeof(ch));
+    if (ret < 0) {
+    	return ret;
+    }
 
     if (ch != '0') {
         *value = 1;
@@ -323,8 +343,12 @@ int gpio_set_edge(unsigned int gpio, unsigned int edge)
         if ((fd = open(filename, O_WRONLY)) < 0)
         return -1;
 
-        write(fd, stredge[edge], strlen(stredge[edge]) + 1);
+        int ret = write(fd, stredge[edge], strlen(stredge[edge]) + 1);
         close(fd);
+        if (ret < 0) {
+        	return ret;
+        }
+
         return 0;
 }
 

source/spimodule.c

@@ -36,6 +36,7 @@
 #if PY_MAJOR_VERSION < 3
 #	define PyLong_AS_LONG(val) PyInt_AS_LONG(val)
 #	define PyLong_AsLong(val) PyInt_AsLong(val)
+#	undef  PyLong_Check
 #	define PyLong_Check(val) PyInt_Check(val)
 #endif
 
@@ -870,7 +871,11 @@ initSPI(void)
 	PyObject* m;
 
 	if (PyType_Ready(&SPI_type) < 0)
+#if PY_MAJOR_VERSION >= 3
+		return NULL;
+#else
 		return;
+#endif
 
 #if PY_MAJOR_VERSION >= 3
 	m = PyModule_Create(&moduledef);