Skip to content

Conversation

@mannycarrera4
Copy link
Contributor

Summary

Fixes: #3551
Add script to convert our upgrade guide mdx files into .md to help MCP server get the correct resources.

Release Category

Infrastructure


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4
Copy link
Contributor Author

I think the following should change:

  • if the file exists in the folder, don't add it
  • strip any unnecessary imports
  • only happen on release CI or every push?

@cypress
Copy link

cypress bot commented Oct 22, 2025

Workday/canvas-kit    Run #9691

Run Properties:  status check passed Passed #9691  •  git commit e597bb770b ℹ️: Merge 99c060640f2fd8ca7739d3def683e40cc3a67b44 into a34bc9e314fe058627b50fe5917b...
Project Workday/canvas-kit
Branch Review mc-mdxUpgrades2md
Run status status check passed Passed #9691
Run duration 02m 54s
Commit git commit e597bb770b ℹ️: Merge 99c060640f2fd8ca7739d3def683e40cc3a67b44 into a34bc9e314fe058627b50fe5917b...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 936
View all changes introduced in this branch ↗︎
UI Coverage  20.66%
  Untested elements 1434  
  Tested elements 371  
Accessibility  99.28%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 98  

@mannycarrera4 mannycarrera4 marked this pull request as ready for review October 24, 2025 16:43
@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Oct 27, 2025
@mannycarrera4 mannycarrera4 moved this to 👀 In review in Canvas Kit Oct 27, 2025
Copy link
Member

@alanbsmith alanbsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like some of the content wasn't properly inserted and was instead replaced with ;. I won't link it, but this PR reminded me of Lonely Island's Semicolon video.

@@ -0,0 +1,516 @@
# Canvas Kit 13.0 Upgrade Guide
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanbsmith these files look much better now ;

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels Oct 28, 2025
@alanbsmith alanbsmith merged commit ecf81e4 into Workday:support Oct 28, 2025
19 of 20 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants