feat: add resolve method for async computed #7881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5432199 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR is to discuss as it adds new public API for async computed |
Varixo
force-pushed
the
v2-async-read-value
branch
from
d84bb2a to
73e92e9
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Sep 9, 2025
| error: Error | null; | ||
| loading: boolean; | ||
| // (undocumented) | ||
| resolve(): Promise<void>; |
|
@Varixo should we also add |
Varixo
force-pushed
the
v2-async-read-value
branch
from
73e92e9 to
5432199
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async
resolvefunction has been added. It should be used to avoid reruning code beforeasynccomputed.valueduring resolving a promise