Skip to content

Commit 5432199

Browse files
committed
feat: make async computed resolve return value
1 parent e1ca73e commit 5432199

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

packages/docs/src/routes/api/qwik/api.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1773,7 +1773,7 @@
17731773
}
17741774
],
17751775
"kind": "MethodSignature",
1776-
"content": "```typescript\nresolve(): Promise<void>;\n```\n**Returns:**\n\nPromise&lt;void&gt;",
1776+
"content": "```typescript\nresolve(): Promise<T>;\n```\n**Returns:**\n\nPromise&lt;T&gt;",
17771777
"mdFile": "core.asynccomputedreadonlysignal.resolve.md"
17781778
},
17791779
{

packages/docs/src/routes/api/qwik/index.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3612,12 +3612,12 @@ StreamWriter
36123612
## resolve
36133613
36143614
```typescript
3615-
resolve(): Promise<void>;
3615+
resolve(): Promise<T>;
36163616
```
36173617
36183618
**Returns:**
36193619
3620-
Promise&lt;void&gt;
3620+
Promise&lt;T&gt;
36213621
36223622
## Resource
36233623

packages/qwik/src/core/qwik.core.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export interface AsyncComputedReadonlySignal<T = unknown> extends ComputedSignal
2525
error: Error | null;
2626
loading: boolean;
2727
// (undocumented)
28-
resolve(): Promise<void>;
28+
resolve(): Promise<T>;
2929
}
3030

3131
// @public (undocumented)

packages/qwik/src/core/reactive-primitives/impl/async-computed-signal-impl.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ export class AsyncComputedSignalImpl<T>
103103
this.$promiseValue$ = NEEDS_COMPUTATION;
104104
}
105105

106-
async resolve(): Promise<void> {
106+
async resolve(): Promise<T> {
107107
await retryOnPromise(() => this.$computeIfNeeded$());
108+
return this.$untrackedValue$;
108109
}
109110

110111
$computeIfNeeded$() {

packages/qwik/src/core/reactive-primitives/signal.public.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface AsyncComputedReadonlySignal<T = unknown> extends ComputedSignal
2121
loading: boolean;
2222
/** The error that occurred while computing the signal. */
2323
error: Error | null;
24-
resolve(): Promise<void>;
24+
resolve(): Promise<T>;
2525
}
2626

2727
/**

0 commit comments

Comments
 (0)