Skip to content

fix: metametric scroll removed for small screen #37220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2025
+11 −12
Merged

fix: metametric scroll removed for small screen #37220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b3e656
fix: metametric scroll removed for small screen
smgv Oct 27, 2025
c313c10
fix: e2e test cases
smgv Oct 27, 2025
5d48549
Merge branch 'main' into fix/metametric-scroll-issue
smgv Oct 27, 2025
f5b93d6
fix: cursor comments
smgv Oct 27, 2025
674292c
Merge branch 'main' into fix/metametric-scroll-issue
smgv Oct 28, 2025
d3eb292
Merge branch 'main' into fix/metametric-scroll-issue
smgv Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/_locales/en/messages.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/_locales/en_GB/messages.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/e2e/page-objects/pages/onboarding/onboarding-metrics-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class OnboardingMetricsPage {
'.mm-checkbox__input#metametrics-opt-in';

private readonly metametricsMessage = {
text: 'Help us improve MetaMask',
text: 'Help improve MetaMask',
tag: 'h2',
};

Expand Down
12 changes: 6 additions & 6 deletions ui/pages/onboarding-flow/metametrics/__snapshots__/metametrics.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ exports[`Onboarding Metametrics Component renders match snapshot 1`] = `
data-testid="onboarding-metametrics"
>
<h2
class="mm-box mm-text mm-text--heading-lg mm-text--font-weight-bold mm-text--text-align-left mm-box--margin-bottom-4 mm-box--color-text-default"
class="mm-box mm-text mm-text--heading-lg mm-text--font-weight-bold mm-text--text-align-left mm-box--color-text-default"
>
Help us improve MetaMask
Help improve MetaMask
</h2>
<div
class="mm-box onboarding-metametrics__user-control mm-box--display-flex mm-box--justify-content-center mm-box--align-items-center mm-box--width-full"
>
<img
alt="User control"
height="200"
height="175"
src="images/user-control.png"
width="200"
/>
Expand Down Expand Up @@ -120,16 +120,16 @@ exports[`Onboarding Metametrics Component renders match snapshot after new polic
data-testid="onboarding-metametrics"
>
<h2
class="mm-box mm-text mm-text--heading-lg mm-text--font-weight-bold mm-text--text-align-left mm-box--margin-bottom-4 mm-box--color-text-default"
class="mm-box mm-text mm-text--heading-lg mm-text--font-weight-bold mm-text--text-align-left mm-box--color-text-default"
>
Help us improve MetaMask
Help improve MetaMask
</h2>
<div
class="mm-box onboarding-metametrics__user-control mm-box--display-flex mm-box--justify-content-center mm-box--align-items-center mm-box--width-full"
>
<img
alt="User control"
height="200"
height="175"
src="images/user-control.png"
width="200"
/>
Expand Down
2 changes: 1 addition & 1 deletion ui/pages/onboarding-flow/metametrics/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}

&__user-control {
height: 200px;
height: 175px;
width: 200px;
margin: 0 auto;
}
Expand Down
3 changes: 1 addition & 2 deletions ui/pages/onboarding-flow/metametrics/metametrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ export default function OnboardingMetametrics() {
variant={TextVariant.headingLg}
textAlign={TextAlign.Left}
fontWeight={FontWeight.Bold}
marginBottom={4}
>
{t('onboardingMetametricsTitle')}
</Text>
Expand All @@ -175,7 +174,7 @@ export default function OnboardingMetametrics() {
<img
src="images/user-control.png"
alt="User control"
height={200}
height={175}
width={200}
/>
</Box>
Expand Down
Loading