-
Couldn't load subscription status.
- Fork 5.4k
fix: metametric scroll removed for small screen #37220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +1 -1)
🔐 @MetaMask/web3auth (3 files, +8 -9)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1b3e656]
UI Startup Metrics (1284 ± 90 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f5b93d6]
UI Startup Metrics (1263 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm QA
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [674292c]
UI Startup Metrics (1278 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
In this PR, I updated the MetaMetric UI to remove scroll state when the user opens it on small-screen devices.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-218
Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=12818-150216&m=dev
Changelog
CHANGELOG entry: Removed scroll state for MetaMetric UI when opening it on small-screen devices.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Shortens the MetaMetrics onboarding title and reduces the user-control image height to 175px, updating locales, UI styles, snapshots, and E2E selectors accordingly.
Help improve MetaMaskand remove extra bottom margin on the title inui/pages/onboarding-flow/metametrics/metametrics.js.200to175viaindex.scssand component<img>.onboardingMetametricsTitlestring inapp/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.test/e2e/.../onboarding-metrics-page.ts.Written by Cursor Bugbot for commit 674292c. This will update automatically on new commits. Configure here.