feat: cantina audit changes on mainnet release #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation:** We were missing a function declaration in `IDelegationManager.sol`. **Modifications:** Added `queuedWithdrawals` interface declaration and `inheritdoc` tag. **Result:** All functions **should** be included in the interface.
github-actions
bot
added
✨ Enhancement
**Motivation:** Address cosmetic issues brought up for the native restaking system **Modifications:** 1. Updates `withdrawRestakedBeaconChainETH` to note that we don't have to pass in a whole-gwei amount 2. Removes `bytesLib` from EigenPod. Also moves the file into the test folder 3. Marks `PAUSED_WITHDRAW_RESTAKED_ETH` as deprecated in `EigenPodPausingConstants` **Result:** Cleaner Contracts.
github-actions
bot
added
the
🧪 Test
**Motivation:** *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* Fix for high sev bug found in Cantina competition. **Modifications:** Contract Changes (EPM): - Safecasting uint256 `depositSharesToRemove` to int256 since this input is provided by the user through `DelegationManager.queueWithdrawals` Tests: - Unit test `testFuzz_removeDepositShares_revert_depositSharesOverflow` which does not bound fuzzed values of `depositSharesToRemove` and checks for casting overflow, negative shares, or a valid input - Removed all `uint224` usage in the EPM unit tests - Regression test POC showing the inflation of staker shares based on original finding `testFuzz_deposit_revertOverflow_queueWithdrawal` Screenshot below is test with the expectedRevert message commented out and with original unsafe casting implementation in the EPM. We can clearly see the depositSharesAfter is much larger than originally... <img width="1884" alt="image" src="https://github.com/user-attachments/assets/77bbbabc-04d8-4761-a102-820f65089534" /> Updated Certora Spec: - Fixed certora parametric rule `integrityOfRemoveDepositShares` to not constrain input values and assert invalid input does not affect depositShares. Updated rule passes here https://prover.certora.com/output/748112/55c59f0cc8144022afe5c22dd1818b77/?anonymousKey=850e5552efec6219cdf5c386b6dc1d62629138e9 <img width="1372" alt="image" src="https://github.com/user-attachments/assets/5f26451e-0894-48e0-9b4c-eb48e34ed1b4" /> **Result:** Fix for bug --------- Co-authored-by: Yash Patil <[email protected]>
**Motivation:** DSF reset isn't emitting event on a full withdrawal. **Modifications:** Added event and shadowed declaration to resolve stack too deep **Result:** Easier for front-end to track dsf changes. --------- Co-authored-by: Michael <[email protected]>
eigenmikem
approved these changes
Apr 3, 2025
wadealexc
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Apply Cantina audit changes to mainnet.
Modifications:
Result:
Fixes applied to mainnet