Skip to content

Conversation

eigenmikem
Copy link
Contributor

Motivation:

DSF reset isn't emitting event on a full withdrawal.

Modifications:

Added event and shadowed declaration to resolve stack too deep

Result:

Easier for front-end to track dsf changes.

@eigenmikem eigenmikem added ✨ Enhancement New feature or request. ⚖️ Audit Fix Audit-related fixes. labels Apr 1, 2025
@github-actions github-actions bot added the 🧪 Test Test-related changes (unit, integration, etc.). label Apr 1, 2025
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do this:

            if (sharesAfter == 0) {
                DepositScalingFactor storage _dsf = _depositScalingFactor[staker][strategies[i]];
                _dsf.reset();
                emit DepositScalingFactorUpdated(staker, strategies[i], _dsf.scalingFactor());
            }

I don't get a stack too deep

wadealexc
wadealexc previously approved these changes Apr 2, 2025
Copy link
Contributor

@wadealexc wadealexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree with Yash, but IMO it's a bit cleaner to just use a storage pointer at the top of the method.

@0xClandestine 0xClandestine self-requested a review April 2, 2025 19:03
@ypatil12 ypatil12 merged commit 0653af4 into dev Apr 2, 2025
11 checks passed
@ypatil12 ypatil12 deleted the mike/dsf-event branch April 2, 2025 19:04
ypatil12 pushed a commit that referenced this pull request Apr 2, 2025
**Motivation:**

DSF reset isn't emitting event on a full withdrawal.

**Modifications:**

Added event and shadowed declaration to resolve stack too deep

**Result:**

Easier for front-end to track dsf changes.

---------

Co-authored-by: Michael <[email protected]>
ypatil12 pushed a commit that referenced this pull request Apr 2, 2025
**Motivation:**

DSF reset isn't emitting event on a full withdrawal.

**Modifications:**

Added event and shadowed declaration to resolve stack too deep

**Result:**

Easier for front-end to track dsf changes.

---------

Co-authored-by: Michael <[email protected]>
ypatil12 added a commit that referenced this pull request Apr 2, 2025
**Motivation:**

Upgrade contracts post Cantina Audit 

**Modifications:**

We upgrade the `DelegationManager`, `EigenPodManager`, and `EigenPod`
based on the following PRs:

- #1270
- #1272
- #1265
- #1271

**Result:**

Preprod/Testnet Upgrade Scripts
bowenli86 pushed a commit that referenced this pull request Apr 2, 2025
**Motivation:**

DSF reset isn't emitting event on a full withdrawal.

**Modifications:**

Added event and shadowed declaration to resolve stack too deep

**Result:**

Easier for front-end to track dsf changes.

---------

Co-authored-by: Michael <[email protected]>
bowenli86 pushed a commit that referenced this pull request Apr 2, 2025
**Motivation:**

Upgrade contracts post Cantina Audit 

**Modifications:**

We upgrade the `DelegationManager`, `EigenPodManager`, and `EigenPod`
based on the following PRs:

- #1270
- #1272
- #1265
- #1271

**Result:**

Preprod/Testnet Upgrade Scripts
ypatil12 added a commit that referenced this pull request Apr 3, 2025
**Motivation:**

Apply Cantina audit changes to mainnet. 

**Modifications:**

- #1270
- #1272
- #1265
- #1271

**Result:**

Fixes applied to mainnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚖️ Audit Fix Audit-related fixes. ✨ Enhancement New feature or request. 🧪 Test Test-related changes (unit, integration, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants