Skip to content

Conversation

@lpatino10
Copy link
Contributor

Related to https://github.ibm.com/Watson/developer-experience/issues/7520

This PR changes the order in which we search for external credential files, moving the search for a file in the current working directory up just after the user-defined path.

@lpatino10 lpatino10 requested a review from padamstx September 16, 2019 18:05
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2019

CLA assistant check
All committers have signed the CLA.

@lpatino10 lpatino10 added the ready-for-review PR is ready for a review label Sep 16, 2019
@lpatino10
Copy link
Contributor Author

@padamstx I didn't make that slight logic change Taj did in this commit because our code was set up a bit differently. He was doing validation of the file in that first method that got simplified, while I'm making sure it's a valid file in the getFirstExistingFileContents method.

The change didn't really simplify things in this case, just move code around, so I decided to leave it.

Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpatino10 lpatino10 merged commit e3d5330 into master Sep 16, 2019
@lpatino10 lpatino10 deleted the env-file-order branch September 16, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review PR is ready for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants