refactor: Change order of files checked for authentication (#59)

Author: lpatino10

src/main/java/com/ibm/cloud/sdk/core/util/CredentialUtils.java

@@ -196,25 +196,29 @@ public static String getVcapValue(String serviceName, String key, String plan) {
   /**
    * Creates a list of files to check for credentials. The file locations are:
    * * Location provided by user-specified IBM_CREDENTIALS_FILE environment variable
+   * * Current working directory this code is being called in
    * * System home directory (Unix)
    * * System home directory (Windows)
-   * * Top-level directory of the project this code is being called in
    *
    * @return list of credential files to check
    */
   private static List<File> getFilesToCheck() {
     List<File> files = new ArrayList<>();
 
     String userSpecifiedPath = EnvironmentUtils.getenv("IBM_CREDENTIALS_FILE");
+    String currentWorkingDirectory = System.getProperty("user.dir");
     String unixHomeDirectory = EnvironmentUtils.getenv("HOME");
     String windowsFirstHomeDirectory = EnvironmentUtils.getenv("HOMEDRIVE") + EnvironmentUtils.getenv("HOMEPATH");
     String windowsSecondHomeDirectory = EnvironmentUtils.getenv("USERPROFILE");
-    String projectDirectory = System.getProperty("user.dir");
 
     if (StringUtils.isNotEmpty(userSpecifiedPath)) {
       files.add(new File(userSpecifiedPath));
     }
 
+    if (StringUtils.isNotEmpty(currentWorkingDirectory)) {
+      files.add(new File(String.format("%s/%s", currentWorkingDirectory, DEFAULT_CREDENTIAL_FILE_NAME)));
+    }
+
     if (StringUtils.isNotEmpty(unixHomeDirectory)) {
       files.add(new File(String.format("%s/%s", unixHomeDirectory, DEFAULT_CREDENTIAL_FILE_NAME)));
     }
@@ -227,10 +231,6 @@ private static List<File> getFilesToCheck() {
       files.add(new File(String.format("%s/%s", windowsSecondHomeDirectory, DEFAULT_CREDENTIAL_FILE_NAME)));
     }
 
-    if (StringUtils.isNotEmpty(projectDirectory)) {
-      files.add(new File(String.format("%s/%s", projectDirectory, DEFAULT_CREDENTIAL_FILE_NAME)));
-    }
-
     return files;
   }