-
Notifications
You must be signed in to change notification settings - Fork 315
Updated spotless and formatters to latest versions. #9869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated spotless and formatters to latest versions. #9869
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037966
Total [baseline] (8.725 s) : 0, 8725390
Agent [candidate] (1.031 s) : 0, 1030580
Total [candidate] (8.702 s) : 0, 8701981
section iast
Agent [baseline] (1.162 s) : 0, 1162095
Total [baseline] (9.367 s) : 0, 9366633
Agent [candidate] (1.16 s) : 0, 1159771
Total [candidate] (9.364 s) : 0, 9364098
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (708.081 ms) : 0, 708081
BytebuddyAgent [candidate] (703.0 ms) : 0, 703000
GlobalTracer [baseline] (246.593 ms) : 0, 246593
GlobalTracer [candidate] (244.987 ms) : 0, 244987
AppSec [baseline] (32.434 ms) : 0, 32434
AppSec [candidate] (32.209 ms) : 0, 32209
Debugger [baseline] (6.441 ms) : 0, 6441
Debugger [candidate] (6.305 ms) : 0, 6305
Remote Config [baseline] (682.884 µs) : 0, 683
Remote Config [candidate] (689.743 µs) : 0, 690
Telemetry [baseline] (15.119 ms) : 0, 15119
Telemetry [candidate] (15.136 ms) : 0, 15136
Flare Poller [baseline] (5.765 ms) : 0, 5765
Flare Poller [candidate] (5.583 ms) : 0, 5583
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (824.331 ms) : 0, 824331
BytebuddyAgent [candidate] (823.698 ms) : 0, 823698
GlobalTracer [baseline] (234.272 ms) : 0, 234272
GlobalTracer [candidate] (233.258 ms) : 0, 233258
IAST [baseline] (32.576 ms) : 0, 32576
IAST [candidate] (32.098 ms) : 0, 32098
AppSec [baseline] (28.966 ms) : 0, 28966
AppSec [candidate] (28.815 ms) : 0, 28815
Debugger [baseline] (6.076 ms) : 0, 6076
Debugger [candidate] (6.084 ms) : 0, 6084
Remote Config [baseline] (608.168 µs) : 0, 608
Remote Config [candidate] (600.873 µs) : 0, 601
Telemetry [baseline] (8.374 ms) : 0, 8374
Telemetry [candidate] (8.331 ms) : 0, 8331
Flare Poller [baseline] (4.125 ms) : 0, 4125
Flare Poller [candidate] (4.125 ms) : 0, 4125
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1031055
Total [baseline] (10.878 s) : 0, 10878038
Agent [candidate] (1.03 s) : 0, 1029979
Total [candidate] (10.836 s) : 0, 10835699
section appsec
Agent [baseline] (1.207 s) : 0, 1206962
Total [baseline] (11.006 s) : 0, 11006399
Agent [candidate] (1.207 s) : 0, 1207169
Total [candidate] (10.874 s) : 0, 10873554
section iast
Agent [baseline] (1.161 s) : 0, 1161429
Total [baseline] (11.131 s) : 0, 11130984
Agent [candidate] (1.16 s) : 0, 1159808
Total [candidate] (11.076 s) : 0, 11075998
section profiling
Agent [baseline] (1.177 s) : 0, 1176831
Total [baseline] (10.952 s) : 0, 10951776
Agent [candidate] (1.182 s) : 0, 1182075
Total [candidate] (10.899 s) : 0, 10898662
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (702.781 ms) : 0, 702781
BytebuddyAgent [candidate] (702.669 ms) : 0, 702669
GlobalTracer [baseline] (245.104 ms) : 0, 245104
GlobalTracer [candidate] (245.041 ms) : 0, 245041
AppSec [baseline] (32.363 ms) : 0, 32363
AppSec [candidate] (31.936 ms) : 0, 31936
Debugger [baseline] (6.405 ms) : 0, 6405
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (680.175 µs) : 0, 680
Remote Config [candidate] (672.027 µs) : 0, 672
Telemetry [baseline] (15.122 ms) : 0, 15122
Telemetry [candidate] (14.384 ms) : 0, 14384
Flare Poller [baseline] (5.736 ms) : 0, 5736
Flare Poller [candidate] (6.282 ms) : 0, 6282
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (728.52 ms) : 0, 728520
BytebuddyAgent [candidate] (730.502 ms) : 0, 730502
GlobalTracer [baseline] (236.525 ms) : 0, 236525
GlobalTracer [candidate] (236.485 ms) : 0, 236485
AppSec [baseline] (175.111 ms) : 0, 175111
AppSec [candidate] (173.739 ms) : 0, 173739
Debugger [baseline] (5.913 ms) : 0, 5913
Debugger [candidate] (5.869 ms) : 0, 5869
Remote Config [baseline] (627.023 µs) : 0, 627
Remote Config [candidate] (621.858 µs) : 0, 622
Telemetry [baseline] (8.478 ms) : 0, 8478
Telemetry [candidate] (8.337 ms) : 0, 8337
Flare Poller [baseline] (3.865 ms) : 0, 3865
Flare Poller [candidate] (3.801 ms) : 0, 3801
IAST [baseline] (25.234 ms) : 0, 25234
IAST [candidate] (25.134 ms) : 0, 25134
section iast
crashtracking [baseline] (1.515 ms) : 0, 1515
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (823.889 ms) : 0, 823889
BytebuddyAgent [candidate] (823.641 ms) : 0, 823641
GlobalTracer [baseline] (233.645 ms) : 0, 233645
GlobalTracer [candidate] (232.93 ms) : 0, 232930
AppSec [baseline] (28.852 ms) : 0, 28852
AppSec [candidate] (29.613 ms) : 0, 29613
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (605.477 µs) : 0, 605
Remote Config [candidate] (593.288 µs) : 0, 593
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.416 ms) : 0, 8416
Flare Poller [baseline] (4.165 ms) : 0, 4165
Flare Poller [candidate] (4.145 ms) : 0, 4145
IAST [baseline] (32.78 ms) : 0, 32780
IAST [candidate] (31.531 ms) : 0, 31531
section profiling
ProfilingAgent [baseline] (109.561 ms) : 0, 109561
ProfilingAgent [candidate] (110.456 ms) : 0, 110456
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (729.047 ms) : 0, 729047
BytebuddyAgent [candidate] (732.138 ms) : 0, 732138
GlobalTracer [baseline] (220.51 ms) : 0, 220510
GlobalTracer [candidate] (221.736 ms) : 0, 221736
AppSec [baseline] (32.36 ms) : 0, 32360
AppSec [candidate] (33.416 ms) : 0, 33416
Debugger [baseline] (12.466 ms) : 0, 12466
Debugger [candidate] (11.494 ms) : 0, 11494
Remote Config [baseline] (1.495 ms) : 0, 1495
Remote Config [candidate] (1.513 ms) : 0, 1513
Telemetry [baseline] (9.883 ms) : 0, 9883
Telemetry [candidate] (9.94 ms) : 0, 9940
Flare Poller [baseline] (4.147 ms) : 0, 4147
Flare Poller [candidate] (4.088 ms) : 0, 4088
Profiling [baseline] (110.201 ms) : 0, 110201
Profiling [candidate] (111.104 ms) : 0, 111104
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (18.251 ms) : 18067, 18436
. : milestone, 18251,
appsec (19.534 ms) : 19331, 19737
. : milestone, 19534,
code_origins (19.617 ms) : 19423, 19810
. : milestone, 19617,
iast (18.422 ms) : 18234, 18610
. : milestone, 18422,
profiling (20.309 ms) : 20106, 20512
. : milestone, 20309,
tracing (19.273 ms) : 19082, 19465
. : milestone, 19273,
section candidate
no_agent (16.895 ms) : 16727, 17064
. : milestone, 16895,
appsec (19.277 ms) : 19077, 19476
. : milestone, 19277,
code_origins (18.299 ms) : 18113, 18485
. : milestone, 18299,
iast (18.492 ms) : 18307, 18676
. : milestone, 18492,
profiling (20.507 ms) : 20301, 20714
. : milestone, 20507,
tracing (19.69 ms) : 19486, 19894
. : milestone, 19690,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.149 ms) : 3107, 3191
. : milestone, 3149,
iast_FULL (5.829 ms) : 5771, 5887
. : milestone, 5829,
iast_GLOBAL (3.734 ms) : 3671, 3798
. : milestone, 3734,
profiling (1.943 ms) : 1927, 1959
. : milestone, 1943,
tracing (1.783 ms) : 1768, 1798
. : milestone, 1783,
section candidate
no_agent (1.191 ms) : 1179, 1202
. : milestone, 1191,
iast (3.121 ms) : 3087, 3155
. : milestone, 3121,
iast_FULL (5.414 ms) : 5362, 5467
. : milestone, 5414,
iast_GLOBAL (3.719 ms) : 3667, 3770
. : milestone, 3719,
profiling (1.926 ms) : 1909, 1943
. : milestone, 1926,
tracing (1.792 ms) : 1778, 1807
. : milestone, 1792,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.721 ms) : 3502, 3940
. : milestone, 3721,
iast (2.197 ms) : 2133, 2260
. : milestone, 2197,
iast_GLOBAL (2.261 ms) : 2197, 2325
. : milestone, 2261,
profiling (2.088 ms) : 2035, 2141
. : milestone, 2088,
tracing (2.031 ms) : 1982, 2081
. : milestone, 2031,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.67 ms) : 3456, 3883
. : milestone, 3670,
iast (2.219 ms) : 2155, 2284
. : milestone, 2219,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.062 ms) : 2010, 2113
. : milestone, 2062,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d0a4248e11, baseline=1.55.0-SNAPSHOT~8747faa1b4
dateFormat X
axisFormat %s
section baseline
no_agent (15.509 s) : 15509000, 15509000
. : milestone, 15509000,
appsec (14.721 s) : 14721000, 14721000
. : milestone, 14721000,
iast (18.817 s) : 18817000, 18817000
. : milestone, 18817000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
profiling (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
tracing (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
section candidate
no_agent (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
appsec (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
iast (18.732 s) : 18732000, 18732000
. : milestone, 18732000,
iast_GLOBAL (18.287 s) : 18287000, 18287000
. : milestone, 18287000,
profiling (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
|
* Try longer benchmark time * Half warmup time * Run benchmarks for longer * Change to two reps and 165s warmup time * Revert timeout back to 1h
if we have a thread in a loop that cannot exit the instrumented method for a while, instrumentation cannot be done. But probe is removed from metadata and cannot be resolved. We were logging this status which is in fact not helpful and generate noise. If probe cannot be resolved we just ignore the instrumentation
Bumps the gh-actions-packages group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gh-actions-packages - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions-packages ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add option to JDBC instrumentation to always append DBM comment DBMON-5791 * document the newly added DBM environment variable * flip order of comment append condition in JDBC instrumentation * use static final variable to decide if we should append SQL comment * reformat code to be spotless * fix typo in the newly added environment variable
* Extract Spark Plan product with keys for Scala 2.13 * Extract Spark Plan product values for Spark 2.12 * Update tests for meta field in Spark SQL plans * Remove unused logic to parse children, enrich product parsing to support more types and use JSON arrays * Update tests to assert on meta values * Use Abstract class for common functions * Use Jackson JSON parser instead of rolling own parsing * Refactor AbstractSparkPlanUtils to only require key generation on impl * Default to returning null if class not recognized, limit recursion depth and array length * Improve testing scheme for Spark32 on Scala 212 with unknown keys * Improve method & class naming, reuse ObjectMapper from listener * Gate Spark Plan parsing with flag * Match classes by string comparison, add negative cache * Add unit tests for AbstractSparkPlanSerializer * Make ObjectMapper protected on AbstractDatadogSparkListener instead of public * Specify correct helper class names * Add dd.data.jobs.experimental_features.enabled FF * Remove knownMatchingTypes override from version-specific impls * Catch NullPointerException for getDeclaredMethod calls * Adjust more gates to match classes using string comparison * Revert "Catch NullPointerException for getDeclaredMethod calls" This reverts commit 5527ad0. * Explicit cast to String on simpleString calls * Use toMap to convert mutable to immutable map in Scala 2.12 * Improvements from comments: use singleton, string concat instead of format, add FF to supported-configurations.json properly * Avoid merge conflict, reorder flags * Exit loop early, store reflected methods as class fields
For SymDB we add injectible lines into method scope to provide information about executable line of code where we can put a line probe. We are using the LineNumberTable of each method, sort and make ranges about them.
|
🎯 Code Coverage 🔗 Commit SHA: d0a4248 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
What Does This Do
Updated spotless and formatters to latest versions.
Motivation
o ensure the project uses the latest tooling and maintains consistent, up-to-date code formatting.
Additional Notes
Requires Java 21.