-
Notifications
You must be signed in to change notification settings - Fork 315
Use dynamic child pipelines for CiVis test environment trigger #9814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamic child pipelines for CiVis test environment trigger #9814
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: e996b7c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032128
Total [baseline] (10.811 s) : 0, 10810602
Agent [candidate] (1.029 s) : 0, 1029124
Total [candidate] (10.933 s) : 0, 10932819
section appsec
Agent [baseline] (1.204 s) : 0, 1203731
Total [baseline] (10.954 s) : 0, 10954321
Agent [candidate] (1.219 s) : 0, 1219156
Total [candidate] (11.087 s) : 0, 11087021
section iast
Agent [baseline] (1.163 s) : 0, 1163223
Total [baseline] (11.176 s) : 0, 11175573
Agent [candidate] (1.164 s) : 0, 1163511
Total [candidate] (11.178 s) : 0, 11178405
section profiling
Agent [baseline] (1.174 s) : 0, 1173950
Total [baseline] (10.92 s) : 0, 10919720
Agent [candidate] (1.181 s) : 0, 1181054
Total [candidate] (10.992 s) : 0, 10991556
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (703.949 ms) : 0, 703949
BytebuddyAgent [candidate] (701.772 ms) : 0, 701772
GlobalTracer [baseline] (245.194 ms) : 0, 245194
GlobalTracer [candidate] (244.69 ms) : 0, 244690
AppSec [baseline] (32.409 ms) : 0, 32409
AppSec [candidate] (32.144 ms) : 0, 32144
Debugger [baseline] (6.402 ms) : 0, 6402
Debugger [candidate] (6.383 ms) : 0, 6383
Remote Config [baseline] (679.603 µs) : 0, 680
Remote Config [candidate] (668.606 µs) : 0, 669
Telemetry [baseline] (14.47 ms) : 0, 14470
Telemetry [candidate] (15.147 ms) : 0, 15147
Flare Poller [baseline] (6.345 ms) : 0, 6345
Flare Poller [candidate] (5.736 ms) : 0, 5736
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (726.777 ms) : 0, 726777
BytebuddyAgent [candidate] (736.987 ms) : 0, 736987
GlobalTracer [baseline] (236.191 ms) : 0, 236191
GlobalTracer [candidate] (239.347 ms) : 0, 239347
IAST [baseline] (25.009 ms) : 0, 25009
IAST [candidate] (25.406 ms) : 0, 25406
AppSec [baseline] (174.442 ms) : 0, 174442
AppSec [candidate] (175.374 ms) : 0, 175374
Debugger [baseline] (5.871 ms) : 0, 5871
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (623.985 µs) : 0, 624
Remote Config [candidate] (650.203 µs) : 0, 650
Telemetry [baseline] (8.386 ms) : 0, 8386
Telemetry [candidate] (8.638 ms) : 0, 8638
Flare Poller [baseline] (3.888 ms) : 0, 3888
Flare Poller [candidate] (3.964 ms) : 0, 3964
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (825.238 ms) : 0, 825238
BytebuddyAgent [candidate] (825.302 ms) : 0, 825302
GlobalTracer [baseline] (234.628 ms) : 0, 234628
GlobalTracer [candidate] (234.931 ms) : 0, 234931
IAST [baseline] (34.195 ms) : 0, 34195
IAST [candidate] (33.312 ms) : 0, 33312
AppSec [baseline] (27.259 ms) : 0, 27259
AppSec [candidate] (27.893 ms) : 0, 27893
Debugger [baseline] (6.15 ms) : 0, 6150
Debugger [candidate] (6.111 ms) : 0, 6111
Remote Config [baseline] (610.376 µs) : 0, 610
Remote Config [candidate] (593.419 µs) : 0, 593
Telemetry [baseline] (8.375 ms) : 0, 8375
Telemetry [candidate] (8.47 ms) : 0, 8470
Flare Poller [baseline] (4.065 ms) : 0, 4065
Flare Poller [candidate] (4.103 ms) : 0, 4103
section profiling
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (727.109 ms) : 0, 727109
BytebuddyAgent [candidate] (731.251 ms) : 0, 731251
GlobalTracer [baseline] (220.501 ms) : 0, 220501
GlobalTracer [candidate] (221.766 ms) : 0, 221766
AppSec [baseline] (32.246 ms) : 0, 32246
AppSec [candidate] (32.327 ms) : 0, 32327
Debugger [baseline] (11.406 ms) : 0, 11406
Debugger [candidate] (12.325 ms) : 0, 12325
Remote Config [baseline] (1.476 ms) : 0, 1476
Remote Config [candidate] (715.913 µs) : 0, 716
Telemetry [baseline] (10.71 ms) : 0, 10710
Telemetry [candidate] (10.58 ms) : 0, 10580
Flare Poller [baseline] (4.117 ms) : 0, 4117
Flare Poller [candidate] (4.21 ms) : 0, 4210
ProfilingAgent [baseline] (109.568 ms) : 0, 109568
ProfilingAgent [candidate] (110.768 ms) : 0, 110768
Profiling [baseline] (110.205 ms) : 0, 110205
Profiling [candidate] (111.435 ms) : 0, 111435
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046617
Total [baseline] (8.728 s) : 0, 8727619
Agent [candidate] (1.033 s) : 0, 1033262
Total [candidate] (8.722 s) : 0, 8722277
section iast
Agent [baseline] (1.164 s) : 0, 1164181
Total [baseline] (9.381 s) : 0, 9381262
Agent [candidate] (1.164 s) : 0, 1163997
Total [candidate] (9.422 s) : 0, 9421830
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (713.737 ms) : 0, 713737
BytebuddyAgent [candidate] (704.954 ms) : 0, 704954
GlobalTracer [baseline] (248.216 ms) : 0, 248216
GlobalTracer [candidate] (245.876 ms) : 0, 245876
AppSec [baseline] (32.984 ms) : 0, 32984
AppSec [candidate] (32.424 ms) : 0, 32424
Debugger [baseline] (6.515 ms) : 0, 6515
Debugger [candidate] (6.41 ms) : 0, 6410
Remote Config [baseline] (695.365 µs) : 0, 695
Remote Config [candidate] (681.811 µs) : 0, 682
Telemetry [baseline] (13.105 ms) : 0, 13105
Telemetry [candidate] (14.517 ms) : 0, 14517
Flare Poller [baseline] (8.299 ms) : 0, 8299
Flare Poller [candidate] (5.771 ms) : 0, 5771
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (824.843 ms) : 0, 824843
BytebuddyAgent [candidate] (825.621 ms) : 0, 825621
GlobalTracer [baseline] (235.397 ms) : 0, 235397
GlobalTracer [candidate] (234.415 ms) : 0, 234415
AppSec [baseline] (29.882 ms) : 0, 29882
AppSec [candidate] (29.964 ms) : 0, 29964
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (609.213 µs) : 0, 609
Remote Config [candidate] (620.613 µs) : 0, 621
Telemetry [baseline] (8.52 ms) : 0, 8520
Telemetry [candidate] (8.437 ms) : 0, 8437
Flare Poller [baseline] (4.162 ms) : 0, 4162
Flare Poller [candidate] (4.156 ms) : 0, 4156
IAST [baseline] (31.853 ms) : 0, 31853
IAST [candidate] (31.89 ms) : 0, 31890
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (36.963 ms) : 36662, 37264
. : milestone, 36963,
appsec (47.257 ms) : 46845, 47670
. : milestone, 47257,
code_origins (43.553 ms) : 43171, 43935
. : milestone, 43553,
iast (45.321 ms) : 44915, 45728
. : milestone, 45321,
profiling (47.207 ms) : 46749, 47664
. : milestone, 47207,
tracing (43.594 ms) : 43226, 43962
. : milestone, 43594,
section candidate
no_agent (37.057 ms) : 36750, 37363
. : milestone, 37057,
appsec (48.589 ms) : 48171, 49006
. : milestone, 48589,
code_origins (43.647 ms) : 43276, 44017
. : milestone, 43647,
iast (44.914 ms) : 44526, 45303
. : milestone, 44914,
profiling (47.477 ms) : 46984, 47971
. : milestone, 47477,
tracing (42.625 ms) : 42261, 42990
. : milestone, 42625,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (4.33 ms) : 4278, 4382
. : milestone, 4330,
iast (10.278 ms) : 10102, 10454
. : milestone, 10278,
iast_FULL (14.393 ms) : 14107, 14679
. : milestone, 14393,
iast_GLOBAL (10.48 ms) : 10293, 10667
. : milestone, 10480,
profiling (9.142 ms) : 8988, 9295
. : milestone, 9142,
tracing (7.857 ms) : 7743, 7972
. : milestone, 7857,
section candidate
no_agent (4.312 ms) : 4262, 4361
. : milestone, 4312,
iast (9.75 ms) : 9581, 9919
. : milestone, 9750,
iast_FULL (14.73 ms) : 14438, 15021
. : milestone, 14730,
iast_GLOBAL (10.667 ms) : 10461, 10873
. : milestone, 10667,
profiling (9.178 ms) : 9036, 9321
. : milestone, 9178,
tracing (8.271 ms) : 8149, 8393
. : milestone, 8271,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
appsec (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
iast (18.456 s) : 18456000, 18456000
. : milestone, 18456000,
iast_GLOBAL (18.222 s) : 18222000, 18222000
. : milestone, 18222000,
profiling (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
tracing (15.355 s) : 15355000, 15355000
. : milestone, 15355000,
section candidate
no_agent (15.491 s) : 15491000, 15491000
. : milestone, 15491000,
appsec (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
iast (18.542 s) : 18542000, 18542000
. : milestone, 18542000,
iast_GLOBAL (17.741 s) : 17741000, 17741000
. : milestone, 17741000,
profiling (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
tracing (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e996b7c000, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.74 ms) : 3521, 3959
. : milestone, 3740,
iast (2.218 ms) : 2154, 2281
. : milestone, 2218,
iast_GLOBAL (2.261 ms) : 2197, 2324
. : milestone, 2261,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.025 ms) : 1976, 2075
. : milestone, 2025,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.721 ms) : 3503, 3938
. : milestone, 3721,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.078 ms) : 2025, 2131
. : milestone, 2078,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
|
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
Test Environment - spring_bootJob Status: success
|
Test Environment - sonar-javaJob Status: success
|
What Does This Do
ci-visibility-tests-check- Executes the.gitlab/ci_visibility_generate_job.shscript which will check if a GitHub PR is opened for the current branch and, if so, will check forcomp: ci visibilityin its labels. If both checks pass, it dynamically generates the.ymlwith aci-visibility-test-environmentjob. If any of the checks don't pass, the generated.ymlcontains a noop jobskip-ci-visibility-tests. This job won't be configured and executed inmasterandrelease/*branches.ci-visibility-tests-trigger- Uses the dynamically generatedci-visibility-test-environment.ymlas a trigger job. Thestrategy: dependconfiguration means that it will wait for the downstream pipeline to finish and mimic its status (passed or failed).ci-visibility-testsstage for clarity.Motivation
This new approach allows to dynamically configure if the test environment pipeline should run or not without depending on configuring this conditional with
check-ci-visibility-labelpassing or not. Even when the check worked correctly, the failed job could cause confusion, especially for developers not familiar with the logic.Additional Notes
Tested examples:
default-pipelineis marked as failed too, blocking the merge.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-2768