-
Couldn't load subscription status.
- Fork 314
Fix JUnit 5 Cucumber instrumentation for version 7.28.1 #9474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JUnit 5 Cucumber instrumentation for version 7.28.1 #9474
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: c84ce10 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052180
Total [baseline] (8.634 s) : 0, 8634120
Agent [candidate] (1.061 s) : 0, 1060777
Total [candidate] (8.684 s) : 0, 8684431
section iast
Agent [baseline] (1.179 s) : 0, 1179182
Total [baseline] (9.394 s) : 0, 9394422
Agent [candidate] (1.181 s) : 0, 1180773
Total [candidate] (9.374 s) : 0, 9374490
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (736.124 ms) : 0, 736124
BytebuddyAgent [candidate] (739.855 ms) : 0, 739855
GlobalTracer [baseline] (243.6 ms) : 0, 243600
GlobalTracer [candidate] (245.948 ms) : 0, 245948
AppSec [baseline] (30.501 ms) : 0, 30501
AppSec [candidate] (30.668 ms) : 0, 30668
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.204 ms) : 0, 6204
Remote Config [baseline] (699.733 µs) : 0, 700
Remote Config [candidate] (699.944 µs) : 0, 700
Telemetry [baseline] (12.504 ms) : 0, 12504
Telemetry [candidate] (14.682 ms) : 0, 14682
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (850.906 ms) : 0, 850906
BytebuddyAgent [candidate] (852.671 ms) : 0, 852671
GlobalTracer [baseline] (232.699 ms) : 0, 232699
GlobalTracer [candidate] (232.877 ms) : 0, 232877
AppSec [baseline] (28.009 ms) : 0, 28009
AppSec [candidate] (27.815 ms) : 0, 27815
Debugger [baseline] (5.828 ms) : 0, 5828
Debugger [candidate] (7.508 ms) : 0, 7508
Remote Config [baseline] (616.37 µs) : 0, 616
Remote Config [candidate] (591.967 µs) : 0, 592
Telemetry [baseline] (8.341 ms) : 0, 8341
Telemetry [candidate] (8.297 ms) : 0, 8297
IAST [baseline] (30.243 ms) : 0, 30243
IAST [candidate] (28.491 ms) : 0, 28491
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055378
Total [baseline] (10.764 s) : 0, 10764484
Agent [candidate] (1.048 s) : 0, 1048432
Total [candidate] (10.714 s) : 0, 10714374
section appsec
Agent [baseline] (1.231 s) : 0, 1231138
Total [baseline] (10.793 s) : 0, 10793232
Agent [candidate] (1.224 s) : 0, 1223995
Total [candidate] (10.824 s) : 0, 10823928
section iast
Agent [baseline] (1.19 s) : 0, 1189534
Total [baseline] (10.998 s) : 0, 10997787
Agent [candidate] (1.181 s) : 0, 1180677
Total [candidate] (10.912 s) : 0, 10911881
section profiling
Agent [baseline] (1.202 s) : 0, 1202014
Total [baseline] (10.895 s) : 0, 10894903
Agent [candidate] (1.2 s) : 0, 1200496
Total [candidate] (10.86 s) : 0, 10859626
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (736.65 ms) : 0, 736650
BytebuddyAgent [candidate] (733.671 ms) : 0, 733671
GlobalTracer [baseline] (244.698 ms) : 0, 244698
GlobalTracer [candidate] (242.783 ms) : 0, 242783
AppSec [baseline] (30.582 ms) : 0, 30582
AppSec [candidate] (30.257 ms) : 0, 30257
Debugger [baseline] (6.172 ms) : 0, 6172
Debugger [candidate] (6.112 ms) : 0, 6112
Remote Config [baseline] (708.372 µs) : 0, 708
Remote Config [candidate] (717.676 µs) : 0, 718
Telemetry [baseline] (13.857 ms) : 0, 13857
Telemetry [candidate] (12.246 ms) : 0, 12246
section appsec
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (760.609 ms) : 0, 760609
BytebuddyAgent [candidate] (755.97 ms) : 0, 755970
GlobalTracer [baseline] (236.813 ms) : 0, 236813
GlobalTracer [candidate] (235.63 ms) : 0, 235630
AppSec [baseline] (169.956 ms) : 0, 169956
AppSec [candidate] (168.367 ms) : 0, 168367
Debugger [baseline] (7.389 ms) : 0, 7389
Debugger [candidate] (7.259 ms) : 0, 7259
Remote Config [baseline] (630.931 µs) : 0, 631
Remote Config [candidate] (608.543 µs) : 0, 609
Telemetry [baseline] (9.266 ms) : 0, 9266
Telemetry [candidate] (10.028 ms) : 0, 10028
IAST [baseline] (23.857 ms) : 0, 23857
IAST [candidate] (23.556 ms) : 0, 23556
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (859.782 ms) : 0, 859782
BytebuddyAgent [candidate] (852.428 ms) : 0, 852428
GlobalTracer [baseline] (234.194 ms) : 0, 234194
GlobalTracer [candidate] (233.19 ms) : 0, 233190
AppSec [baseline] (26.088 ms) : 0, 26088
AppSec [candidate] (28.28 ms) : 0, 28280
Debugger [baseline] (7.555 ms) : 0, 7555
Debugger [candidate] (5.763 ms) : 0, 5763
Remote Config [baseline] (611.056 µs) : 0, 611
Remote Config [candidate] (603.775 µs) : 0, 604
Telemetry [baseline] (8.419 ms) : 0, 8419
Telemetry [candidate] (8.256 ms) : 0, 8256
IAST [baseline] (30.14 ms) : 0, 30140
IAST [candidate] (29.463 ms) : 0, 29463
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (763.762 ms) : 0, 763762
BytebuddyAgent [candidate] (762.822 ms) : 0, 762822
GlobalTracer [baseline] (223.387 ms) : 0, 223387
GlobalTracer [candidate] (223.927 ms) : 0, 223927
AppSec [baseline] (30.636 ms) : 0, 30636
AppSec [candidate] (30.691 ms) : 0, 30691
Debugger [baseline] (6.319 ms) : 0, 6319
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (736.487 µs) : 0, 736
Remote Config [candidate] (700.526 µs) : 0, 701
Telemetry [baseline] (15.76 ms) : 0, 15760
Telemetry [candidate] (16.284 ms) : 0, 16284
ProfilingAgent [baseline] (109.338 ms) : 0, 109338
ProfilingAgent [candidate] (107.748 ms) : 0, 107748
Profiling [baseline] (109.992 ms) : 0, 109992
Profiling [candidate] (108.403 ms) : 0, 108403
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section baseline
no_agent (4.419 ms) : 4364, 4474
. : milestone, 4419,
iast (9.044 ms) : 8897, 9192
. : milestone, 9044,
iast_FULL (13.937 ms) : 13660, 14213
. : milestone, 13937,
iast_GLOBAL (10.598 ms) : 10404, 10792
. : milestone, 10598,
profiling (8.746 ms) : 8600, 8893
. : milestone, 8746,
tracing (7.421 ms) : 7308, 7533
. : milestone, 7421,
section candidate
no_agent (4.303 ms) : 4254, 4353
. : milestone, 4303,
iast (9.687 ms) : 9523, 9852
. : milestone, 9687,
iast_FULL (13.972 ms) : 13697, 14247
. : milestone, 13972,
iast_GLOBAL (10.167 ms) : 9990, 10345
. : milestone, 10167,
profiling (8.468 ms) : 8320, 8615
. : milestone, 8468,
tracing (7.698 ms) : 7587, 7809
. : milestone, 7698,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section baseline
no_agent (36.825 ms) : 36532, 37118
. : milestone, 36825,
appsec (49.399 ms) : 48965, 49833
. : milestone, 49399,
code_origins (45.049 ms) : 44659, 45440
. : milestone, 45049,
iast (44.999 ms) : 44608, 45389
. : milestone, 44999,
profiling (47.275 ms) : 46859, 47692
. : milestone, 47275,
tracing (43.584 ms) : 43204, 43964
. : milestone, 43584,
section candidate
no_agent (36.038 ms) : 35740, 36336
. : milestone, 36038,
appsec (49.706 ms) : 49263, 50149
. : milestone, 49706,
code_origins (43.909 ms) : 43533, 44286
. : milestone, 43909,
iast (43.223 ms) : 42846, 43600
. : milestone, 43223,
profiling (46.456 ms) : 46056, 46857
. : milestone, 46456,
tracing (44.516 ms) : 44129, 44903
. : milestone, 44516,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.596 ms) : 3385, 3807
. : milestone, 3596,
iast (2.202 ms) : 2140, 2264
. : milestone, 2202,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.039 ms) : 1989, 2090
. : milestone, 2039,
tracing (2.009 ms) : 1961, 2057
. : milestone, 2009,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.662 ms) : 3444, 3881
. : milestone, 3662,
iast (2.201 ms) : 2139, 2263
. : milestone, 2201,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.033 ms) : 1983, 2084
. : milestone, 2033,
tracing (2.012 ms) : 1963, 2060
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c84ce10af4, baseline=1.54.0-SNAPSHOT~fa788acdc2
dateFormat X
axisFormat %s
section baseline
no_agent (15.338 s) : 15338000, 15338000
. : milestone, 15338000,
appsec (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
iast (18.442 s) : 18442000, 18442000
. : milestone, 18442000,
iast_GLOBAL (18.261 s) : 18261000, 18261000
. : milestone, 18261000,
profiling (15.173 s) : 15173000, 15173000
. : milestone, 15173000,
tracing (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
section candidate
no_agent (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
appsec (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
iast (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (15.504 s) : 15504000, 15504000
. : milestone, 15504000,
tracing (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
|
What Does This Do
Fixes JUnit 5 Cucumber instrumentation for the latest version 7.28.1.
io.cucumber.junit.platform.engine.NodeDescriptorclass was renamed toio.cucumber.junit.platform.engine.CucumberTestDescriptor$PickleDescriptor.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]