Skip to content

Commit fa788ac

Browse files
authored
Enable performance SLO change tracking (#9447)
* feat: add dd-octo-sts trust policy for GitLab CI GitHub access Add read-only trust policy to enable GitLab CI jobs to access GitHub API for SLO change tracking. Policy allows all branches and tags from the DataDog/apm-reliability/dd-trace-java project. * feat: update check-slo-breaches job to use dd-octo-sts for GitHub access - Add id_tokens configuration for dd-octo-sts authentication - Fetch GitHub token in before_script using dd-octo-sts - Export GITHUB_TOKEN before running bp-runner for SLO tracking - Revoke token in after_script for security * add newline to trust policy * fix: scope trust policy to master branch only * fix: broaden trust policy scope to support manual runs on any branch * feat: Remove notify-slo-breaches version pin to use improved notifications * feat: update check-slo-breaches to use a template * trigger pipeline * trigger pipeline
1 parent c4c1019 commit fa788ac

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
issuer: https://gitlab.ddbuild.io
2+
3+
subject_pattern: "project_path:DataDog/apm-reliability/dd-trace-java:ref_type:(branch|tag):ref:.*"
4+
5+
permissions:
6+
contents: read
7+

.gitlab/macrobenchmarks.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
include:
2-
project: 'DataDog/benchmarking-platform-tools'
3-
file: 'images/templates/gitlab/notify-slo-breaches.template.yml'
4-
ref: '925e0a3e7dd628885f6fc69cdaea5c8cc9e212bc'
2+
- project: 'DataDog/benchmarking-platform-tools'
3+
file: 'images/templates/gitlab/notify-slo-breaches.template.yml'
4+
- project: 'DataDog/benchmarking-platform-tools'
5+
file: 'images/templates/gitlab/check-slo-breaches.template.yml'
56

67
.macrobenchmarks:
78
stage: macrobenchmarks
@@ -76,10 +77,9 @@ otel-latest:
7677

7778

7879
check-slo-breaches:
80+
extends: .check-slo-breaches
7981
stage: macrobenchmarks
8082
interruptible: true
81-
tags: ["arch:amd64"]
82-
image: registry.ddbuild.io/images/benchmarking-platform-tools-ubuntu:latest
8383
rules:
8484
- if: $POPULATE_CACHE
8585
when: never
@@ -127,6 +127,7 @@ check-slo-breaches:
127127
- platform/artifacts/
128128
expire_in: 1 week
129129
variables:
130+
DDOCTOSTS_POLICY: "self.gitlab.github-access.read"
130131
UPSTREAM_PROJECT_ID: $CI_PROJECT_ID # The ID of the current project. This ID is unique across all projects on the GitLab instance.
131132
UPSTREAM_PROJECT_NAME: $CI_PROJECT_NAME # "dd-trace-java"
132133
UPSTREAM_BRANCH: $CI_COMMIT_REF_NAME # The branch or tag name for which project is built.

0 commit comments

Comments
 (0)