Skip to content

Conversation

@mvsnogueira-dnx
Copy link
Contributor

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mvsnogueira-dnx mvsnogueira-dnx self-assigned this Oct 31, 2025
@amazon-q-developer
Copy link

Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command Description
/q <message> Chat with the agent to ask questions or request revisions
/q review Requests an Amazon Q powered code review
/q help Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

  1. Create a .amazonq/rules folder in your project root.
  2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
  3. Write detailed prompts in these files, such as coding standards or best practices.
  4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

  1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy.

Copy link

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR adds support for Python 3.13, which is a valuable addition to keep the Docker images current with the latest Python releases. The implementation follows the existing patterns well, and the test script has been properly updated.

Positive Changes

  • New Python 3.13 Dockerfile follows the established structure and patterns
  • Serverless Framework updated from 3.36.0 to 3.40.0 across all versions (good maintenance)
  • Test build script properly includes Python 3.13
  • Consistent formatting and structure across all Dockerfiles

⚠️ Critical Issues to Address

  1. Missing Makefile Updates: The Makefile lacks build and push commands for Python 3.13, which will prevent CI/CD from working properly
  2. Pip Version Issue: All Dockerfiles specify pip version 25.1.1, which appears to be from the future and could cause build failures

📋 Recommendations

  • Update the Makefile to include Python 3.13 build and push commands
  • Consider removing the pip version pin or using a more conservative version (e.g., latest stable 24.x)
  • Test the Docker builds locally to ensure they work with the current pip version

The core functionality looks solid, but the missing Makefile updates make this PR incomplete for production use.


Coming soon: You'll be able to request the agent to implement changes and create commits on your pull request's source branch. This may trigger any configured CI/CD workflows automatically.

You can disable any CI/CD workflow that you have configured to run on the source branch of the pull request. For more information, see Disabling and enabling a workflow in the GitHub documentation.

apt-get update && \
apt-get install -y nodejs && \
npm install -g serverless@3.36.0 && \
npm install -g serverless@3.40.0 && \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update to Serverless Framework from 3.36.0 to 3.40.0. This brings bug fixes and improvements. However, consider the same pip version issue that exists in this file as well.

-t ${DOCKER_REPO}:3.12-${DOCKER_TAG} \
..

echo "Building Python 3.13..."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition of Python 3.13 build to the test script. This ensures the new Docker image gets built and tested along with the existing versions. The formatting and structure are consistent with the existing build commands.


WORKDIR /work

ENTRYPOINT ["/bin/sh"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Critical Missing Update: The Makefile needs to be updated to include build and push commands for Python 3.13. Without this, the CI/CD pipeline won't build or publish the Python 3.13 image.

apt-get update && \
apt-get install -y nodejs && \
npm install -g serverless@3.36.0 && \
npm install -g serverless@3.40.0 && \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Serverless Framework update from 3.36.0 to 3.40.0 is good and brings improvements. However, all Dockerfiles in this PR have the same pip version issue (25.1.1) that should be addressed consistently across all Python versions.

@mvsnogueira-dnx mvsnogueira-dnx merged commit 7b38ff3 into master Oct 31, 2025
2 checks passed
@adenot adenot deleted the version_3.13 branch November 2, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants