-
Notifications
You must be signed in to change notification settings - Fork 5
Adding support to python 3.13 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⏳ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion. Using Amazon Q Developer for GitHubAmazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation. Slash Commands
FeaturesAgentic Chat Code Review CustomizationYou can create project-specific rules for Amazon Q Developer to follow:
Example rule: FeedbackTo provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository. For more detailed information, visit the Amazon Q for GitHub documentation. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
This PR adds support for Python 3.13, which is a valuable addition to keep the Docker images current with the latest Python releases. The implementation follows the existing patterns well, and the test script has been properly updated.
✅ Positive Changes
- New Python 3.13 Dockerfile follows the established structure and patterns
- Serverless Framework updated from 3.36.0 to 3.40.0 across all versions (good maintenance)
- Test build script properly includes Python 3.13
- Consistent formatting and structure across all Dockerfiles
⚠️ Critical Issues to Address
- Missing Makefile Updates: The
Makefilelacks build and push commands for Python 3.13, which will prevent CI/CD from working properly - Pip Version Issue: All Dockerfiles specify pip version 25.1.1, which appears to be from the future and could cause build failures
📋 Recommendations
- Update the
Makefileto include Python 3.13 build and push commands - Consider removing the pip version pin or using a more conservative version (e.g., latest stable 24.x)
- Test the Docker builds locally to ensure they work with the current pip version
The core functionality looks solid, but the missing Makefile updates make this PR incomplete for production use.
Coming soon: You'll be able to request the agent to implement changes and create commits on your pull request's source branch. This may trigger any configured CI/CD workflows automatically.
You can disable any CI/CD workflow that you have configured to run on the source branch of the pull request. For more information, see Disabling and enabling a workflow in the GitHub documentation.
| apt-get update && \ | ||
| apt-get install -y nodejs && \ | ||
| npm install -g serverless@3.36.0 && \ | ||
| npm install -g serverless@3.40.0 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update to Serverless Framework from 3.36.0 to 3.40.0. This brings bug fixes and improvements. However, consider the same pip version issue that exists in this file as well.
| -t ${DOCKER_REPO}:3.12-${DOCKER_TAG} \ | ||
| .. | ||
|
|
||
| echo "Building Python 3.13..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition of Python 3.13 build to the test script. This ensures the new Docker image gets built and tested along with the existing versions. The formatting and structure are consistent with the existing build commands.
|
|
||
| WORKDIR /work | ||
|
|
||
| ENTRYPOINT ["/bin/sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Critical Missing Update: The Makefile needs to be updated to include build and push commands for Python 3.13. Without this, the CI/CD pipeline won't build or publish the Python 3.13 image.
| apt-get update && \ | ||
| apt-get install -y nodejs && \ | ||
| npm install -g serverless@3.36.0 && \ | ||
| npm install -g serverless@3.40.0 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Serverless Framework update from 3.36.0 to 3.40.0 is good and brings improvements. However, all Dockerfiles in this PR have the same pip version issue (25.1.1) that should be addressed consistently across all Python versions.
15221e5 to
783399c
Compare
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...