Skip to content

Disable 05-cspSsgPresets #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Disable 05-cspSsgPresets #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bbb8c0
Disable 05-cspSsgPresets
vejja Jan 17, 2024
0c69444
adapt tests
vejja Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,13 +312,16 @@ function registerSecurityNitroPlugins(nuxt: Nuxt, securityOptions: ModuleOptions
)

// Register nitro plugin to enable CSP Headers presets for SSG
// TEMPORARILY DISABLED AS NUXT 3.9.3 PREVENTS IMPORTING @NUXT/KIT IN NITRO PLUGINS
/*
config.plugins.push(
normalize(
fileURLToPath(
new URL('./runtime/nitro/plugins/05-cspSsgPresets', import.meta.url)
)
)
)
*/

// Nitro plugin to enable CSP Nonce for SSR
config.plugins.push(
Expand Down
6 changes: 6 additions & 0 deletions test/perRoute.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,10 +832,13 @@ describe('[nuxt-security] Per-route Configuration', async () => {

it('does not inject CSP hashes on a deeply-disabled route', async () => {
const res = await fetch('/csp-hash/deep/disabled')
// DISABLING THIS PART OF THE TEST AFTER PATCH #348 THAT REMOVES CSP SSG PRESETS
/*
const cspHeaderValue = res.headers.get('content-security-policy')
expect(cspHeaderValue).toBeDefined()
const headerHashes = cspHeaderValue!.match(/'sha256-(.*?)'/)
expect(headerHashes).toBeNull()
*/

const text = await res.text()
const head = text.match(/<head>(.*?)<\/head>/s)?.[1]
Expand All @@ -849,10 +852,13 @@ describe('[nuxt-security] Per-route Configuration', async () => {

it('injects CSP hashes on a deeply-enabled route', async () => {
const res = await fetch('/csp-hash/deep/enabled')
// DISABLING THIS PART OF THE TEST AFTER PATCH #348 THAT REMOVES CSP SSG PRESETS
/*
const cspHeaderValue = res.headers.get('content-security-policy')
expect(cspHeaderValue).toBeDefined()
const headerHashes = cspHeaderValue!.match(/'sha256-(.*?)'/)
expect(headerHashes).toHaveLength(2)
*/

const text = await res.text()
const head = text.match(/<head>(.*?)<\/head>/s)?.[1]
Expand Down