Skip to content

Conversation

@vejja
Copy link
Collaborator

@vejja vejja commented Jan 17, 2024

Fixes #348
Fixes #335

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This patch removes the cspSsgPresets functionality to temporarily solve issues #335 and #348, while we work on an alternative solution.

This patch is required after Nuxt 3.9.3 introduced protection against importing @nuxt/kit in Nitro plugins, which breaks 05-cspSsgPresets.ts in our module.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 3:32pm

@Baroshem
Copy link
Owner

Some tests are not passing and was wondering if it is caused by the removing of the module or can we skip it?

@vejja
Copy link
Collaborator Author

vejja commented Jan 17, 2024

Some tests are not passing and was wondering if it is caused by the removing of the module or can we skip it?

Sorry I was too quick in hitting create
Tests now modified - passing alright now

@Baroshem
Copy link
Owner

Ok thanks for that @vejja !

I am off right now but will release a patch version in the evening with your change.

@Baroshem Baroshem merged commit bda8026 into main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"This module cannot be imported in server runtime" error on fresh Nuxt install Error deploying to Cloudflare Workers after upgrade beyond rc.2

2 participants