CMake: Fix Cortex-M33 GCC build #14313
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugueskamba
requested review from
0xc0170,
Patater,
harmut01,
rajkan01 and
saheerb
ciarmcom
added
the
release-type: patch
Member
|
@hugueskamba, thank you for your changes. |
0xc0170
previously approved these changes
Feb 22, 2021
Contributor
|
CI started |
Patater
previously requested changes
Feb 22, 2021
Collaborator
Author
|
@Patater @0xc0170 |
Contributor
Following the docs rather than following what the old tool did seems the best course of action. |
The GCC flag to specify the floating-point hardware (`mfpu`) does not accept the value `none`. The default value is `auto` which causes the compiler to select the floating-point and Advanced SIMD instructions based on the settings of -mcpu and -march. The extension option `+nofp` has been added to disable floating point instructions.
hugueskamba
force-pushed
the
hk_cmake_fix_cortex_m33_gcc
branch
from
47ec637 to
cd6cb71
Compare
mergify
bot
dismissed stale reviews from 0xc0170 and Patater
Pull request has been modified.
Contributor
|
@jeromecoutant Please review (previously reported other M33 issues). |
0xc0170
approved these changes
Feb 22, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Contributor
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Patater
approved these changes
Feb 23, 2021
LDong-Arm
approved these changes
Feb 23, 2021
Contributor
LDong-Arm
left a comment
LDong-Arm
left a comment
There was a problem hiding this comment.
Would be good to have this merged soon, as CMake support for a few TF-M/PSA repos depends on it
mbedmain
added
release-version: 6.9.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The GCC flag to specify the floating-point hardware (
mfpu) does not acceptthe value
none. The default value isautowhich causes the compiler toselect the floating-point and Advanced SIMD instructions based on the
settings of -mcpu and -march. The extension option
+nofphas been addedto disable floating point instructions.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers