Skip to content

Support Mbed CLI 2 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2021
Merged

Support Mbed CLI 2 #20

merged 3 commits into from
Mar 5, 2021

Conversation

@LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Feb 22, 2021 •
edited
Loading

This is based on CMakeLists.txt from mbed-os-example-blinky, with mbed-psa added to the list of libraries to link.
The Travis script has been changed to build with Mbed CLI 2 (only) to align with other Mbed official examples (e.g. mbed-os-example-blinky).

Tested:

  • Compilation for K64F, ARM_MUSCA_B1, ARM_MUSCA_S1
  • Running on K64F (we can only run it on Musca B1 and S1 after we added post binary hooks for them)

hugueskamba
hugueskamba reviewed Feb 22, 2021
View reviewed changes
@LDong-Arm LDong-Arm force-pushed the cmake_support branch 3 times, most recently from 5153ca5 to 4dfce79 Compare February 25, 2021 15:15
jainvikas8
jainvikas8 reviewed Feb 25, 2021
View reviewed changes
@LDong-Arm LDong-Arm force-pushed the cmake_support branch 2 times, most recently from 0dcfd99 to 64e1184 Compare March 2, 2021 14:25
@LDong-Arm LDong-Arm mentioned this pull request Mar 2, 2021
Merged
@LDong-Arm LDong-Arm changed the title Add CMakeLists.txt to support Mbed CLI 2 Support Mbed CLI 2 Mar 2, 2021
evedon
evedon approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good

LDong-Arm added 2 commits March 3, 2021 10:06
@LDong-Arm
Support Mbed CLI 2
fa85617 
This commit adds CMakeLists.txt to support Mbed CLI 2, and updates
README with build steps aligned with other official Mbed examples.
@LDong-Arm
Travis: add compile tests for Mbed CLI 2
be6d797
@LDong-Arm LDong-Arm force-pushed the cmake_support branch 8 times, most recently from eac40b9 to 5e53fbb Compare March 3, 2021 10:54
@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Mar 3, 2021

Sorry for the many force pushes. After many trials and errors, Circle CI finally works!

@jamesbeyond
Copy link

jamesbeyond commented Mar 3, 2021

Can we use docker in Travis? I think that will save the problem of downloading tools, and make the flow neat

@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Mar 3, 2021 •
edited
Loading

Can we use docker in Travis? I think that will save the problem of downloading tools, and make the flow neat

This should be aligned for all Mbed OS official examples, none of which use Mbed OS docker for Travis. I can change this particular PR, but for consistency we should refactor all of them. @0xc0170

@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Mar 3, 2021 •
edited
Loading

The scope of this PR is to update existing scripts to use Mbed CLI 2.
For the use of a Docker image in Travis, I'm happy to create a separate PR to experiment that, but there's no existing example I can simply use - even the mbed-os Travis is not using Docker. There would be quite a bit of experimentation involved (e.g. how Travis's ccache, which is pretty automatic and speeds up builds, can work in a container environment.)

Here's Travis's documentation: https://docs.travis-ci.com/user/docker/
The use of Docker in Travis requires manual management (docker pull/run/...) and is not an automatic process like CircleCI.

@evedon
Copy link
Contributor

evedon commented Mar 4, 2021

The scope of this PR is to update existing scripts to use Mbed CLI 2.

I agree that to use Mbed OS docker for Travis is not in scope. Let's not do any work on this now as the work needs to be prioritised first.

@evedon
Copy link
Contributor

evedon commented Mar 4, 2021

@hugueskamba @0xc0170 Can one of you review the cmake changes please?

@hugueskamba
Copy link

hugueskamba commented Mar 4, 2021

@hugueskamba @0xc0170 Can one of you review the cmake changes please?

The CMake LGTM.

@evedon evedon merged commit e5585ba into ARMmbed:development Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainvikas8 jainvikas8 jainvikas8 left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LDong-Arm @jamesbeyond @evedon @hugueskamba @0xc0170 @jainvikas8