Skip to content

Conversation

@mikaleppanen
Copy link

Summary of changes

Corrected Wi-SUN certificate add and remove functions to work properly with .json certificates. .json certificates are used only if certificates added by add functions are not set. Corrected certificate add and remove functions to work properly and improved function descriptions.

This is mbed-os-5.15 version of: #14018

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin


…face

Corrected Wi-SUN certificate add and remove functions to work properly
with .json certificates. .json certificates are used only if certificates
added by add functions are not set. Corrected certificate add and remove
functions to work properly and improved function descriptions.
@ciarmcom ciarmcom requested review from a team, artokin and mikter December 15, 2020 13:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

adbridge commented Jan 7, 2021

@artokin @mikter can you review please?

@mergify mergify bot added needs: CI and removed needs: review labels Jan 7, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 20, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

Once travis fix lands to 5.15, this will go into CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 46a045b into ARMmbed:mbed-os-5.15 Jan 25, 2021
@mergify mergify bot removed the ready for merge label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants