Corrected Wi-SUN certificate add and remove functions on Wi-SUN interface #14018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face Corrected Wi-SUN certificate add and remove functions to work properly with .json certificates. .json certificates are used only if certificates added by add functions are not set. Corrected certificate add and remove functions to work properly and improved function descriptions.
|
@mikaleppanen, thank you for your changes. |
mikter
reviewed
Dec 9, 2020
| int wisun_tasklet_remove_trusted_certificates(void) | ||
| { | ||
| return wisun_tasklet_store_certificate_data(NULL, 0, NULL, 0, false, true, false); | ||
| if (wisun_tasklet_data_ptr && wisun_tasklet_data_ptr->network_interface_id != INVALID_INTERFACE_ID && wisun_tasklet_data_ptr->configured_and_connected) { |
There was a problem hiding this comment.
if you remove own that were set with add function does it start using MbedOS defaults?
There was a problem hiding this comment.
yes, the removing will take the .json certifications into use.
artokin
approved these changes
Dec 11, 2020
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
0xc0170
approved these changes
Dec 14, 2020
mikter
approved these changes
Dec 14, 2020
This was referenced Dec 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Corrected Wi-SUN certificate add and remove functions to work properly with .json certificates. .json certificates are used only if certificates added by add functions are not set. Corrected certificate add and remove functions to work properly and improved function descriptions.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@mikter @artokin