Skip to content

Privacy workaround wb55 #13759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Privacy workaround wb55 #13759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1842cc
BLE: Workaround for WB55 connection event
pan- Oct 13, 2020
2a4a097
BLE: Take advantage of controller based address resolution on WB55
pan- Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions connectivity/FEATURE_BLE/mbed_lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@
"target_overrides": {
"MCU_NRF52840": {
"ble-gap-host-based-private-address-resolution": false
},
"NUCLEO_WB55RG": {
"ble-gap-host-based-private-address-resolution": false
}
}
}
16 changes: 14 additions & 2 deletions connectivity/FEATURE_BLE/source/cordio/source/PalGapImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,18 +364,30 @@ class PalGap final : public ble::PalGap {

static GapConnectionCompleteEvent convert(const hciLeConnCmplEvt_t *conn_evt)
{
const bdAddr_t *peer_rpa = &conn_evt->peerRpa;
const bdAddr_t *peer_address = &conn_evt->peerAddr;

#if defined(TARGET_MCU_STM32WB55xx)
Copy link
Collaborator

@jeromecoutant jeromecoutant Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a bug in the WB55 event controller, you should correct it instead of adding some dirty workaround in this cordio file ?

Copy link
Member Author

@pan- pan- Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @jeromecoutant . The bug is inside the BLE firmware which as far as I know is only proposed as binary. The workaround is not in the cordio sources but on top of it, in Mbed OS interfaces with the Cordio stack. The workaround does not affect devices producing correct enhanced connection events. It doesn't require modification if it is fixed in a new firmware by ST.

I truly believe it is the best place to put the workaround today as users doesn't always update to the latest version of the firmware.Even if ST was releasing a new firmware today, I'd keep the workaround in place to avoid issues with old firmwares.

const bdAddr_t invalidAddress = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
if (conn_evt->addrType == DM_ADDR_RANDOM &&
memcmp(peer_address, invalidAddress, sizeof(invalidAddress)) == 0 &&
memcmp(peer_rpa, invalidAddress, sizeof(invalidAddress) != 0)
) {
std::swap(peer_rpa, peer_address);
}
#endif
return GapConnectionCompleteEvent(
conn_evt->status,
// note the usage of the stack handle, not the HCI handle
conn_evt->hdr.param,
(connection_role_t::type) conn_evt->role,
(peer_address_type_t::type) conn_evt->addrType,
conn_evt->peerAddr,
*peer_address,
conn_evt->connInterval,
conn_evt->connLatency,
conn_evt->supTimeout,
conn_evt->localRpa,
conn_evt->peerRpa
*peer_rpa
);
}
};
Expand Down