Privacy workaround wb55 #13759
Privacy workaround wb55 #13759
Conversation
The connection event reported by the WB55 is incorrect if controller privacy is not enable and the peer connects with an unknown private resolvable address: The RPA field contains the connection address (it should be empty) and the peer address is all FF while it should be equal to the connection address.
| const bdAddr_t *peer_rpa = &conn_evt->peerRpa; | ||
| const bdAddr_t *peer_address = &conn_evt->peerAddr; | ||
|
|
||
| #if defined(TARGET_MCU_STM32WB55xx) |
There was a problem hiding this comment.
If there is a bug in the WB55 event controller, you should correct it instead of adding some dirty workaround in this cordio file ?
There was a problem hiding this comment.
Thanks for the feedback @jeromecoutant . The bug is inside the BLE firmware which as far as I know is only proposed as binary. The workaround is not in the cordio sources but on top of it, in Mbed OS interfaces with the Cordio stack. The workaround does not affect devices producing correct enhanced connection events. It doesn't require modification if it is fixed in a new firmware by ST.
I truly believe it is the best place to put the workaround today as users doesn't always update to the latest version of the firmware.Even if ST was releasing a new firmware today, I'd keep the workaround in place to avoid issues with old firmwares.
|
@pan-, thank you for your changes. |
4 participants
Summary of changes
This PR adds a workaround to a bug in the WB55 event controller. When a connection event is received, the RPA and peer address field are inverted if the peer connects with a resolvable private address.
It also force controller privacy to be used.
Impact of changes
None
Migration actions required
None
Documentation
Internal change, no documentation update required.
Pull request type
Test results
Reviewers
@paul-szczepanek-arm