Ambiq AMA3B1KK and SparkFun Artemis Boards Target Update #13193
Conversation
While the SERAIL API allows you to define this it would appear that the ASYNCH_SERIAL API defines its own serial_t, which simply includes a serial_s member that is user-defined.
While the SERAIL API allows you to define this it would appear that the ASYNCH_SERIAL API defines its own serial_t, which simply includes a serial_s member that is user-defined.
Ambiq apollo3 gpio irq
…utton In Ambiq SDK (TARGET_SFE_ARTEMIS_THING_PLUS/bsp/am_bsp_pins.h) the pin for the on-board user button is already defined. However in TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h there are no pin definitions for the on-board button, as a consequence in mbed-os we can not reference it by the name. Following mbed-os pin naming conventions buttons have a pin name like SW1 (not like BUTTON1). This PR adds a name reference to TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h so that we can use SW1 in mbed-os as an alias for the pin definition defined in the corresponding bsp. I think currently other Artemis boards also lack the mbed pin definition for the on-board button that already exists in the bsp.
|
@Wenn0101 I reopened this PR. The branch If you are having still problem with updating this branch ,we can close this pull request and you can create a new pull request (possibly from different branch or the same one as here). Whatever works for you. |
|
I tried to rebase this locally, it is non trivial for myself as there are conflicts in targets.json and BLE. Let me know if you got any issues with rebasing or recreating this on top of the latest master (it might be easier). |
|
Hello @0xc0170 The branch was updated 14 days ago. A rebase of master into this feature branch is truly non-trivial since we have >100 commits on the branch. A merge of master into the feature branch is much easier but could complicate the eventual revision history. I have created a new branch that squashed all of our commits to a single commit on this feature branch. Would this approach be preferrable? I am still checking to make sure i didn't break anything with this change. |
|
merged changes from master into this branch. Created new PR from a branch that contains a single commit which contains all changes in this PR. |
removes unused comments, consistent brace style
missed one
this adds a new am_hal_uart_configure_fifo function which takes a boolean option whether to enable or disable FIFO operation
… 3 clause license
…ader to all novel files without headers
Update PinNames.h to include user button on the Thing Plus board
Thanks, I'll close this one |
6 participants
Summary of changes
We would like to collect some feedback on the following changes we have been working on.
Add support for Ambiq Micro AMA3B1KK (Apollo3)
Add support for SparkFun Boards which use AMA3B1KK:
-SparkFun Artemis ATP
-SparkFun Artemis DK
-SparkFun Artemis Nano
-SparkFun Artemis Thing Plus
-SparkFun Edge
-SparkFun Edge2
We know that we aren't quite ready for approval, but we are looking for feedback now so that we can make changes. We have been working on this very independently and would appreciate any comments from the Arm Mbed Team.
Things we know we have to change/complete before approval:
-rewrite commit history to meet contribution standards
-troubleshoot 2 failed test cases
Open Questions:
Supported toolchains - Right now we only support GCC_ARM toolchain on this target, do other toolchains need to be added to complete PR?
Impact of changes
Migration actions required
Documentation
MCU Datasheet - https://cdn.sparkfun.com/assets/d/a/7/c/d/Apollo3_Blue_MCU_Data_Sheet_v0_9_1.pdf
Sparkfun product information - https://www.sparkfun.com/artemis
Pull request type
Test results
Reviewers