Update PinNames.h to include user button on the Thing Plus board #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton In Ambiq SDK (TARGET_SFE_ARTEMIS_THING_PLUS/bsp/am_bsp_pins.h) the pin for the on-board user button is already defined. However in TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h there are no pin definitions for the on-board button, as a consequence in mbed-os we can not reference it by the name. Following mbed-os pin naming conventions buttons have a pin name like SW1 (not like BUTTON1). This PR adds a name reference to TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h so that we can use SW1 in mbed-os as an alias for the pin definition defined in the corresponding bsp. I think currently other Artemis boards also lack the mbed pin definition for the on-board button that already exists in the bsp.
idea--list
changed the title
oclyke
changed the base branch from
ambiq-apollo3-dev
to
ambiq-apollo3-arduino
oclyke
changed the base branch from
ambiq-apollo3-arduino
to
ambiq-apollo3-dev
oclyke
approved these changes
Sep 9, 2020
oclyke
left a comment
oclyke
left a comment
There was a problem hiding this comment.
This is a great addition, thanks @idea--list!
Wenn0101
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ambiq SDK (TARGET_SFE_ARTEMIS_THING_PLUS/bsp/am_bsp_pins.h) the pin for the on-board user button is already defined.
However in TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h there are no pin definitions for the on-board button, as a consequence in mbed-os we can not reference it by the name.
Following mbed-os pin naming conventions buttons have a pin name like SW1 (not like BUTTON1).
This PR adds a name reference to TARGET_SFE_ARTEMIS_THING_PLUS/PinNames.h so that we can use SW1 in mbed-os as an alias for the pin definition defined in the corresponding bsp.
I think only the Artemis Thing Plus has an on-board user button, so other boards might not be affected.
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers