Skip to content

Re-enable AWS example, limit targets #13171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2020
Merged

Re-enable AWS example, limit targets #13171

merged 2 commits into from
Jul 3, 2020

Conversation

@LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Jun 22, 2020 •
edited
Loading

Preceding PRs: ARMmbed/mbed-os-example-wifi#195 (merged), https://github.com/ARMmbed/mbed-os-ci/pull/1268 (merged)

Summary of changes

In #13070 we added the AWS example to the test list while leaving it disabled for the release. This PR re-enables it.
Also restrict test targets to DISCO_L475VG_IOT01A (with WiFi) and K64F (with Ethernet).

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team June 22, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 22, 2020

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 25, 2020

Preceding PRs: ARMmbed/mbed-os-example-wifi#195, ARMmbed/mbed-os-ci#1268

Looks like we are waiting on updating CI, wifi example is ready.

@LDong-Arm LDong-Arm changed the title Do Not Merge: Re-enable AWS example, limit targets Re-enable AWS example, limit targets Jul 1, 2020
@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Jul 1, 2020 •
edited
Loading

Preceding PRs: ARMmbed/mbed-os-example-wifi#195, ARMmbed/mbed-os-ci#1268

Looks like we are waiting on updating CI, wifi example is ready.

They are merged now @0xc0170

@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Jul 2, 2020

@0xc0170 Can we trigger CI since it's approved by two people?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jul 3, 2020
@0xc0170 0xc0170 merged commit 57809c4 into ARMmbed:master Jul 3, 2020
@mergify mergify bot removed the ready for merge label Jul 3, 2020
@adbridge adbridge added release-version: 6.2.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evedon evedon evedon approved these changes

+1 more reviewer

@ithinuel ithinuel ithinuel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LDong-Arm @ciarmcom @0xc0170 @mbed-ci @ithinuel @evedon @adbridge