-
Notifications
You must be signed in to change notification settings - Fork 44
Update the list of supported WiFi modules #195
Conversation
|
@jamesbeyond @evedon This adds wifi-ism43362.lib to resolve the CI limitation, as we discussed. Now there's no need for users to manually add any WiFi drivers, so there's a bit of clean up in README. @MarceloSalazar |
|
Perhaps you should put all the drivers .lib file under a single folder (e.g. "drivers") to keep the root directory clean/small? |
2763e43 to
2e72503
Compare
Done |
evedon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
once this PR merged, will need https://github.com/ARMmbed/mbed-os-ci/pull/1268 merge as well |
UBLOX_EVK_ODIN_W2 is not supported in the latest Mbed OS. Also there's no need to fetch wifi-ism43362 separately as it is handled by a .lib file.
|
Can this be merged (I see couple of dependencies here but do not fully understand the full picture in which order they should get in to have PR ARMmbed/mbed-os#13070 passing) ? |
|
Hi @AnttiKauppila @kivaisan @kimlep01, I'm updating the Jenkinsfile in this PR, but the CI isn't picking it up: It still uses the Jenkinsfile from the master branch. Is it due to some permission settings in CI? Reviews on this PR are welcome too, thanks in advance! |
Hi, Jenkins is set to trust forks from admins or write permissions. |
Would you please either commit the Jenkinsfile change for me, or is it possible to give me write permission to this repo? I'm from the PAN team which may probably need permissions in this repo soon anyway. Thanks. |
You should have write access now. |
Thanks a lot, it works now 👍 |
|
@AnttiKauppila can you merge please? |
@evedon I'm afraid we need to keep this on hold, because ARMmbed/mbed-os-ci#1268 seems not ready yet. They need to get in at the same time otherwise the Mbed OS CI will fail. |
|
We need to take some risk - merge this first, so we can test ARMmbed/mbed-os-ci#1268. Mbed OS CI will temporarily not work in between them - let's be quick. @jamesbeyond @evedon |
This PR is created to
COMPONENT_wifi-ism43362.libwhich is for a commonly used WiFi module. This also mean we can get rid of the "quirk" in the Mbed OS CI script to add this driver.