Detect never ending loops #69
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects never ending loops after the method was changed to synchronous code.
Example
From the file WhileNotCancelled.cs in GenerationSandbox.Tests:
Before
The synchronized version of this code will never end, because
!ct.IsCancellationRequestedgets replaced withtrue. The last statement (throw) will also show an error that it'll never be reached:After
In the new version the last statement gets removed:
And a new diagnostic is added (
ZSMGEN004) telling the user that it's detected that the loop will never end:Please validate if the error message is correct or should be changed:
1656a54#diff-59a20cb680fe0e33b6def06d74d7c85b3e090d4c9b716668e145f74715af9fecR29-R35