Provide an option to convert a method with IAsyncEnumerable to IList, ReadOnlySpan, Span #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placements (chose this design as I thought it could be reusable if other types are given options at any point)
ValerieFernandes
force-pushed
the
fix-embedded-resource
branch
from
33ba4d0 to
f3e9358
Compare
virzak
reviewed
Feb 12, 2024
| if (IsReplaceWithAttribute(attributeContainingTypeSymbol) && attributeSyntax.Parent?.Parent is ParameterSyntax param | ||
| && GetSymbol(param) is IParameterSymbol parameterSymbol) | ||
| { | ||
| var variation = parameterSymbol.GetAttributes()[0].NamedArguments.FirstOrDefault(c => c.Key == "Variations").Value.Value; |
There was a problem hiding this comment.
I know you're busy with school and there's 0 urgency on this one. Just making a comment to not forget.
[0] is going to grab a wrong attribute if you have something like [Obsolete] in the first position.
virzak
force-pushed
the
master
branch
2 times, most recently
from
3dfda17 to
b1a312d
Compare
virzak
force-pushed
the
master
branch
3 times, most recently
from
f25c292 to
eafebd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19