Add --js-library support
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburgy
added a commit
to zig-wasm/zorth
that referenced
this pull request
Nov 8, 2025
jburgy
added a commit
to zig-wasm/zorth
that referenced
this pull request
Nov 9, 2025
* Don't Repeat Yourself * Hack around zig-gamedev/zemscripten#16
Copilot finished reviewing on behalf of
hazeycode
November 11, 2025 11:20
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the --js-library flag to the Emscripten build system integration, allowing users to specify custom JavaScript library files. The PR also includes code style improvements and refactoring.
- Added
js_library_pathparameter toStepOptionsfor specifying JavaScript library files - Simplified optional value handling using the
orelseoperator - Added necessary type casts for Emscripten allocator functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.zig | Added js_library_path field to StepOptions and implemented --js-library flag support; removed unused shell_file field from EmccDefaultSettingsOverrides; refactored output file name handling |
| src/zemscripten.zig | Simplified optional value handling with orelse operator; added @intCast for usize to u32 conversions in allocator functions; modified type casting in alignment calculation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Turns out this simple fix turned up a (very trivial) bug in the Zig standard library: ziglang/zig#25899! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://emscripten.org/docs/tools_reference/emcc.html#emcc-js-library