Setting to disable analytics #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at Sep 9, 11:30:09 AM UTC] |
zerts
force-pushed
the
task/extension-add-option-to-disable-analytics-WLT-8206
branch
from
abd89c8 to
0fe2a24
Compare
Comment on lines
+112
to
+114
| if (!explicitly) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
should this condition come first?
There was a problem hiding this comment.
Yes, this is fair. My only logic was to place this settings check as same as possible everywhere to simplify the usage
Comment on lines
+242
to
+245
| const preferences = await globalPreferences.getPreferences(); | ||
| if (!preferences.analyticsEnabled) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This check is repeated over and over. Do you think we can create a helper that abstracts this?
There was a problem hiding this comment.
Discussed and decided to keep it this way for now
zerts
deleted the
task/extension-add-option-to-disable-analytics-WLT-8206
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.