Linker script generator fixes for Windows host. #41588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: zephyrproject-rtos#41435 The use of %<symbol>% works well in Linux and MacOS but when passed to the linker script generator in Windows the %<symbol>% is processed by the windows shell causing the value to disappear and thus an empty value inside the generated ld linker script or scatter file. This is fixed by using the @ character instead of the % character. Signed-off-by: Torsten Rasmussen <[email protected]>
Fixes: zephyrproject-rtos#41435 Remove build host specific escaping of start symbol command argument. The start symbol for armlink is: Image$$device$$Base and were escaped as: Image\\$$\\$$device\\$$\\$$Base However, the $ must only be escaped in Linux and MacOS, not on windows hosts. Instead of escaping the start symbol in the CMake code then it is better to use the VERBATIM flag on `add_custom_command()` which ensures correct escaping for the build host. Signed-off-by: Torsten Rasmussen <[email protected]>
|
@hongshui3000 feel free to test this and provide feedback. |
stephanosio
approved these changes
Jan 6, 2022
SebastianBoe
approved these changes
Jan 6, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #41435
This PR contains two commits fixing issues on Windows hosts for the linker script generator:
VERBATIMflag foradd_custom_command()instead.