fix: Shift navbar down when accesing it on macOS in fullscreen (#8757) #9865
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
mr-cheffy
requested changes
Aug 13, 2025
| + // : ""; | ||
| + const padding = shiftSize > 0 ? `${shiftSize}px` : ""; | ||
| + const appContentNavbarWrapper = document.getElementById('zen-appcontent-navbar-wrapper'); | ||
| + appContentNavbarWrapper.style.paddingTop = gURLBar.textbox.hasAttribute("breakout") |
There was a problem hiding this comment.
Shoudnt we check if it's double toolbar as well?
There was a problem hiding this comment.
Good point, I didn't consider that case, I'll do some tests and try to add it
There was a problem hiding this comment.
I wonder if instead of this fullscreen we can just not hide it at all, like what chromium browsers do.
There was a problem hiding this comment.
You mean like not showing the macOS title bar that shifts down at all? That could work, the window minimize, maximize and close buttons would be lost and should be moved to the toolbar though.
As it is, this fix takes the same solution that firefox did, but I agree the chromium way is more simple. I'll try experimenting to see if I can replicate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift nav bar down when accessing it on macOS while in fullscreen, allowing it to be shown when the macOS top bar appears.
I tried to keep this PR simple, but the nav bar kept auto hiding when the macOS top bar appears making it difficult to access. The changes made in
ZenCompactMode.mjsfixes that.Fixes #8757
EDIT: This is how it currently works
https://github.com/user-attachments/assets/5ad31673-366a-4c65-b6ba-2d2b2a2036ff