Remote LSP logs #36709
Merged
Remote LSP logs #36709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
probably-neb
force-pushed
the
remote-lsp-logs
branch
from
60b182f to
0b5bdd4
Compare
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
6 times, most recently
from
9e5add8 to
03ba256
Compare
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
3 times, most recently
from
4ba48ab to
8e19ab8
Compare
Squawk Report✅ 0 violations across 1 file(s)
|
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
5 times, most recently
from
157bcdb to
53a6c7a
Compare
Co-authored-by: Ben Kunkle <[email protected]> Co-authored-by: Lukas Wirth <[email protected]> # Conflicts: # crates/language_tools/src/lsp_log.rs # crates/remote_server/src/headless_project.rs
Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Ben Kunkle <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
from
5be0804 to
08673a2
Compare
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
from
08673a2 to
2252057
Compare
SomeoneToIgnore
force-pushed
the
remote-lsp-logs
branch
from
2252057 to
3b32c45
Compare
|
Protobuf migration CI failure is due to |
SomeoneToIgnore
added a commit
that referenced
this pull request
Aug 27, 2025
This reverts commit e2bf8e5.
SomeoneToIgnore
added a commit
that referenced
this pull request
Aug 27, 2025
This reverts commit e2bf8e5. See #37050 (comment) for the context: musl builds started to fail and the amount of `cfg!`s to fix this is too large. Instead, the lsp_log.rs has to be split and repurposed better for the remote headless server. Release Notes: - N/A
Merged
SomeoneToIgnore
added a commit
that referenced
this pull request
Aug 28, 2025
Take 2: #36709 but without the very bad `cfg`-based approach for storing the RPC logs. -------------- Enables LSP log tracing in both remote collab and remote ssh environments. Server logs and server RPC traces can now be viewed remotely, and the LSP button is now shown in such projects too. Closes #28557 Co-Authored-By: Kirill <[email protected]> Co-Authored-By: Lukas <[email protected]> Release Notes: - Enabled LSP log tracing in both remote collab and remote ssh environments --------- Co-authored-by: Ben Kunkle <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables LSP log tracing in both remote collab and remote ssh environments.
Server logs and server RPC traces can now be viewed remotely, and the LSP button is now shown in such projects too.
Closes #28557
Co-Authored-By: Kirill [email protected]
Co-Authored-By: Lukas [email protected]
Release Notes: