Skip to content

Names changed according to changed XML tags #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Names changed according to changed XML tags #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
674a5f6
Changed names
aidarbek Dec 26, 2015
179013c
Changed tests according to Last.fm API
aidarbek Dec 26, 2015
456175a
Merge branch 'master' of https://github.com/youpy/ruby-lastfm
aidarbek Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/lastfm/method_category/tag.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Tag < Base
[:page, nil]
]
) do |response|
response.xml['toptracks']['track']
response.xml['tracks']['track']
end

regular_method(
Expand All @@ -31,7 +31,7 @@ class Tag < Base
[:page, nil]
]
) do |response|
response.xml['topalbums']['album']
response.xml['albums']['album']

end

Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/tag_get_top_albums.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<lfm status="ok">
<topalbums tag="Disco" page="1" perPage="5" totalPages="200" total="1000">
<albums tag="Disco" page="1" perPage="5" totalPages="200" total="1000">

<album rank="1">
<name>Number Ones</name>
Expand Down Expand Up @@ -67,4 +67,4 @@
<image size="medium">http://images.amazon.com/images/P/B00002NDAL.01.MZZZZZZZ.jpg</image>
<image size="large">http://images.amazon.com/images/P/B00002NDAL.01.MZZZZZZZ.jpg</image>
<image size="extralarge">http://images.amazon.com/images/P/B00002NDAL.01.MZZZZZZZ.jpg</image>
</album></topalbums></lfm>
</album></albums></lfm>
4 changes: 2 additions & 2 deletions spec/fixtures/tag_get_top_tracks.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<lfm status="ok">
<toptracks tag="Disco" page="1" perPage="5" totalPages="200" total="1000">
<tracks tag="Disco" page="1" perPage="5" totalPages="200" total="1000">

<track rank="1">
<name>Stayin' Alive</name>
Expand Down Expand Up @@ -97,5 +97,5 @@
<image size="medium">http://userserve-ak.last.fm/serve/64s/72573304.png</image>
<image size="large">http://userserve-ak.last.fm/serve/126/72573304.png</image>
<image size="extralarge">http://userserve-ak.last.fm/serve/300x300/72573304.png</image>
</track></toptracks></lfm>
</track></tracks></lfm>