Skip to content

Conversation

@mspirkov
Copy link
Contributor

@mspirkov mspirkov commented Nov 11, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

These types are not currently listed, so no links are generated for them.

https://www.php.net/language.types.iterable
https://www.php.net/language.types.mixed
https://www.php.net/language.types.never
https://www.php.net/language.types.void

@mspirkov mspirkov marked this pull request as ready for review November 11, 2025 12:36
@mspirkov mspirkov marked this pull request as draft November 11, 2025 16:05
@mspirkov mspirkov changed the title Expanded the list of built-in PHP types Expand the list of built-in PHP types Nov 13, 2025
@mspirkov
Copy link
Contributor Author

Something strange is happening with PHP 7.2. It works locally, but not on GitHub.

image image

@mspirkov mspirkov marked this pull request as ready for review November 13, 2025 14:49
@terabytesoftw
Copy link
Member

terabytesoftw commented Nov 13, 2025

You're trying to install 2.0.53 on 7.2, and you have at least 7.3. I think these modifications should be done in a higher version, since it's the support for the PHPStan/Psalm annotations, which are the master version. For now, we should test the master version, and at least 7.4, and when the 2.0.54 release is done for the PHP 8.5 release, then release it with the minimum version of 2.0.54.

There is no point in supporting older versions, which do not have PHPStan/Psalm annotations.

We should test ci from 7.4 to 8.5.

image

@mspirkov
Copy link
Contributor Author

mspirkov commented Nov 13, 2025

I just don't understand how this relates to my latest changes.
I'm in favor of raising the minimum version to 7.4. I was just planning to do that in one of the next requests. Can I do it here, or is it better to raise the minimum version separately?

@terabytesoftw
Copy link
Member

I just don't understand how this relates to my latest changes. I'm in favor of raising the minimum version to 7.4. I was just planning to do that in one of the next requests. Can I do it here, or is it better to raise the minimum version separately?

The CI fails because it tries to install 2.0.53 on 7.2 and its requirement in composer is 7.3. On the other hand, you are making the changes to be able to use the PHPStan/PSalm annotations correctly, so we should try the master (Yii2), which is the one that contains all the changes.

@mspirkov
Copy link
Contributor Author

I mean, everything installed fine here: #319
But now for some reason it doesn't.

@terabytesoftw
Copy link
Member

terabytesoftw commented Nov 13, 2025

I think the problem is the new version of Composer; the commit version you mentioned uses 2.8.12, and the Composer version in this PR is 2.9.1, which introduces several new changes https://blog.packagist.com/composer-2-9/?s=09

image image

https://packagist.org/packages/yiisoft/yii2/advisories?version=8224315

That's the only difference.

@mspirkov
Copy link
Contributor Author

Sounds logical, thank you.

@terabytesoftw
Copy link
Member

Sounds logical, thank you.

I've updated my answer; Composer now doesn't allow the installation of packages with vulnerabilities, it blocks them.

@mspirkov
Copy link
Contributor Author

Then I'll make a PR tomorrow with raising PHP version to 7.4.

@terabytesoftw
Copy link
Member

Then I'll make a PR tomorrow with raising PHP version to 7.4.

And to increase the Yii2 version, for this development we must test the master, which has all the latest changes in the documentation.

@samdark samdark merged commit d96841b into yiisoft:master Nov 14, 2025
4 checks passed
@samdark
Copy link
Member

samdark commented Nov 14, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants