-
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Remove yiisoft/yii2-symfonymailer dependency from composer.json.
#146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoved the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 7 7
===========================================
Files 12 12
Lines 172 172
===========================================
Hits 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
composer.json (1)
13-20: Remove or replace all remaining Symfony Mailer references (or re-add the dependency)
- config/common/components.php (lines 7, 27–30): still imports
yii\symfonymailer\Mailerand configures it as themailercomponent- docs/configuration.md (lines 48, 68–70): still shows
use yii\symfonymailer\Mailerand amailerconfig example- composer.lock (line 8245): still locks
yiisoft/yii2-symfonymailer—after updatingcomposer.json, runcomposer updateto regenerate the lockfileEither remove/replace these imports and config entries (e.g. switch to a NullMailer stub) or restore the package requirement so runtime instantiation won’t fail.
🧹 Nitpick comments (1)
composer.json (1)
13-20: Optional: advertise mailer as an optional feature via Composer “suggest”.If the app supports emailing when users choose to enable it, consider adding a Composer “suggest” entry so developers discover the package without hard requiring it.
Apply:
"require": { "php": ">=8.1", "php-forge/foxy": "^0.1", "ui-awesome/html-svg":"^0.2", "vlucas/phpdotenv": "^5.6", "yiisoft/yii2": "^2.0.53|^22", "yiisoft/yii2-bootstrap5": "^2.0.50|^22" }, + "suggest": { + "yiisoft/yii2-symfonymailer": "Install to enable email sending via Symfony Mailer." + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)composer.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-31T15:34:39.060Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#142
File: README.md:0-0
Timestamp: 2025-08-31T15:34:39.060Z
Learning: In yii2-extensions/app-basic project, the dev-road-runner branch is treated as the main configuration branch with no stable releases available. Static badges pointing to dev branches are intentionally used to direct users to the development version.
Applied to files:
CHANGELOG.md
📚 Learning: 2025-08-31T15:29:19.131Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#142
File: docs/installation.md:21-23
Timestamp: 2025-08-31T15:29:19.131Z
Learning: In yii2-extensions/app-basic project, the composer.json file has "minimum-stability": "dev" configured, which allows Composer to install dev versions automatically without requiring --stability=dev flag in create-project commands.
Applied to files:
composer.json
📚 Learning: 2025-07-09T14:52:41.210Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#97
File: docs/installation.md:5-8
Timestamp: 2025-07-09T14:52:41.210Z
Learning: The Yii2 framework has multiple active branches including the 2.0.x branch (maintenance/LTS) and the 22.0 branch (development). When specifying version requirements, "2.0.53+ or 22.x" is accurate and should not be changed to only reference the 2.x branch.
Applied to files:
composer.json
🔇 Additional comments (1)
CHANGELOG.md (1)
7-7: Entry is clear and scoped.Changelog line accurately documents the dependency removal under 0.1.1 (Under development). No further edits needed.
Summary by CodeRabbit
Bug Fixes
Chores
Documentation
yiisoft/yii2-symfonymailerdependency fromcomposer.json. #146).