add routing of root fields #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now we will disable support for fragment arguments, pending graphql/graphql-js#4389
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the transformation of selection sets to improve root field routing across subschemas. The changes include updating the transformation function from transformForTargetSubschema to transformSelectionSetForTargetSubschema, modifying the executor call and merging logic in transform.ts, and adjusting related utility functions and tests.
- Updated transformSelectionSetForTargetSubschema.ts to focus solely on selection set transformation.
- Revised transform.ts to remove operation-level transformation and introduce routing logic with a new filterGroupedFieldSet and groupedFieldSetToSelectionSet.
- Adjusted completeValue.ts, buildTransformationContext.ts, and addNewLabels.ts along with test updates (including skipping some tests).
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/transform/transformSelectionSetForTargetSubschema.ts | Refactored transformation logic, now accepting selectionSet, fragments, parentType, targetSchema, and prefix. |
| src/transform/transform.ts | Updated routing logic; replaced transformForTargetSubschema with transformSelectionSetForTargetSubschema and added filtering logic. |
| src/transform/groupedFieldSetToSelectionSet.ts | New utility to convert grouped field sets into selection sets with defer support. |
| src/transform/completeValue.ts | Updated to use superschema and remove argsWithNewLabels dependency. |
| src/transform/buildTransformationContext.ts | Updated context building with fragment grouping using the new transformation function. |
| src/transform/addNewLabels.ts | Adjusted signature by splitting operation and fragments. |
| tests files | Various test adjustments and skipping of tests related to fragment arguments and oneof input. |
| cspell.yml, .changeset/silly-berries-retire.md | Minor documentation and configuration updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.