Skip to content

Conversation

liskin
Copy link
Member

@liskin liskin commented Oct 30, 2016

This comes handy if e.g. the focus stealing behaviour of some browsers
is undesirable.

@geekosaur
Copy link
Contributor

Enough people are annoyed by the focus stealing behavior that I have
wondered if it's worth taking the alternative sanctioned by EWMH as our
default: mark the window to be focused as urgent (see
XMonad.Hooks.UrgencyHook) instead of focusing it.

On Sat, Oct 29, 2016 at 8:02 PM, Tomáš Janoušek [email protected]
wrote:

This comes handy if e.g. the focus stealing behaviour of some browsers

is undesirable.

You can view, comment on, or merge this pull request online at:

#110
Commit Summary

  • X.H.EwmhDesktops: add a way to selectively ignore _NET_ACTIVE_WINDOW

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#110, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB8SoBfKjuSNg9cNi5xhMLzmdKMZPXovks5q496lgaJpZM4KkQEk
.

brandon s allbery kf8nh sine nomine associates
[email protected] [email protected]
unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

@liskin
Copy link
Member Author

liskin commented Dec 11, 2016

Maybe. I'm not the right person to ask that, anyway, as I rarely use the defaults, anywhere really.

Anyway, I wanted to warn people that chrome/chromium 55 is broken and will crash when its _NET_ACTIVE_WINDOW requests aren't honored immediately. I'm getting bitten by that several times a day (as I'm unfortunately unable to change my habits quickly). Here's the report: https://bugs.chromium.org/p/chromium/issues/detail?id=670959

@SOwOphie
Copy link

Is anyone still working on this? If not, I'll merge this code with #93 and re-submit...

@liskin
Copy link
Member Author

liskin commented Feb 10, 2017

I sort of intended to look at the design suggested by @geekosaur in #109, but I don't think I'll get to it any time soon. Feel free to use my code in any way you like. :-)

@pjones
Copy link
Contributor

pjones commented Feb 10, 2017

@SirBoonami take a look at #128

@SOwOphie
Copy link

Didn't really have the time to look into it the last few months, but it certainly seems to be a better thought out solution than my clueless fumblings. I'll close my PR in shame and go help this guy out instead =)

@pjones
Copy link
Contributor

pjones commented Apr 10, 2017

Closing as a duplicate since this can be done via #128 now.

@geekosaur
Copy link
Contributor

geekosaur commented Apr 10, 2017 via email

@pjones
Copy link
Contributor

pjones commented Apr 10, 2017

@geekosaur In that case, are you in favor of merging this PR? If so I'll bug @liskin about a CHANGES.md entry and then merge it.

@pjones pjones reopened this Apr 10, 2017
@geekosaur
Copy link
Contributor

As a stopgap, yes. Ideally I'd like something more flexible but it seems like nobody's in a position to write it.

@pjones
Copy link
Contributor

pjones commented Apr 10, 2017

@liskin Please add a CHANGES.md entry and I'll merge.

@liskin
Copy link
Member Author

liskin commented May 7, 2019

First, sorry for not responding, I was somewhat busy at the time and never got to it later. :-(

From reading the code in #128 it seems to me that it does what this one does, and much more. I expect to try it myself soon, but I don't mind if this one is closed sooner if anyone else shares my feeling that it's completely obsoleted by #128.

@liskin
Copy link
Member Author

liskin commented May 7, 2019

Oh, it's been reverted. :-/

@liskin liskin force-pushed the ewmh-ignoreactivation branch from a8a515e to 837804c Compare November 12, 2019 10:39
@liskin liskin force-pushed the ewmh-ignoreactivation branch from 837804c to f945045 Compare April 25, 2020 15:23
@liskin liskin force-pushed the ewmh-ignoreactivation branch from f945045 to a0c971f Compare August 25, 2020 13:30
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Nov 15, 2020
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Nov 16, 2020
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Nov 16, 2020
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Jan 25, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Jan 25, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Jan 30, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Jan 30, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Feb 7, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Feb 7, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Mar 23, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Mar 23, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request Apr 7, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request Apr 7, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request Apr 13, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request Apr 13, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit that referenced this pull request May 16, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Fixes: 45052b9 ("X.H.EwmhDesktops. run 'logHook' for activated window.")
Related: #396
Related: #110
Related: #192
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021
…gnored

This makes window switching apps like rofi and alttab able to activate
windows even if the logHook doesn't activate them (which it doesn't by
default, and that's a regression).

Fixes: 45052b9 ("X.H.EwmhDesktops. run 'logHook' for activated window.")
Related: xmonad#396
Related: xmonad#110
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Jun 4, 2021
TODO: documentation in X.H.EwmhDesktops
TODO: changelog
TODO: adapt X.H.Focus

Related: xmonad#396
Related: xmonad#110
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 18, 2021
These are useful when one blocks some _NET_ACTIVE_WINDOW requests but
still wants to somehow show that a window requested focus.

Related: xmonad#110
Related: xmonad#128
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 18, 2021
These are useful when one blocks some _NET_ACTIVE_WINDOW requests but
still wants to somehow show that a window requested focus.

Related: xmonad#110
Related: xmonad#128
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 19, 2021
These are useful when one blocks some _NET_ACTIVE_WINDOW requests but
still wants to somehow show that a window requested focus.

Related: xmonad#110
Related: xmonad#128
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 19, 2021
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 19, 2021
These are useful when one blocks some _NET_ACTIVE_WINDOW requests but
still wants to somehow show that a window requested focus.

Related: xmonad#110
Related: xmonad#128
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 19, 2021
xmonad#192 introduced a breaking change:

  * `XMonad.Hooks.EwmhDesktops`

    `ewmh` function will use `logHook` for handling activated window. And now
    by default window activation will do nothing.

This breaking change can be avoided if we designed that a bit
differently. xmonad#192 changed `ewmhDesktopsEventHook` to invoke `logHook`
instead of focusing the window that requested activation and now
`logHook` is supposed to invoke a `ManageHook` through `activateLogHook`
which consults a global `NetActivated` extensible state to tell if it's
being invoked from `ewmhDesktopsEventHook`. This seems convoluted to me.

A better design, in my opinion, is to invoke the `ManageHook` directly
from `ewmhDesktopsEventHook`, and we just need a way to configure the
hook. Luckily, we now have `X.U.ExtensibleConf` which makes this
straightforward. So we now have a `setEwmhActivateHook`, and the
activation hook defaults to focusing the window, undoing the breaking
change.

Fixes: xmonad#396
Related: xmonad#110
Related: xmonad#192
Related: xmonad#128
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 20, 2021
xmonad#192 introduced a breaking change:

  * `XMonad.Hooks.EwmhDesktops`

    `ewmh` function will use `logHook` for handling activated window. And now
    by default window activation will do nothing.

This breaking change can be avoided if we designed that a bit
differently. xmonad#192 changed `ewmhDesktopsEventHook` to invoke `logHook`
instead of focusing the window that requested activation and now
`logHook` is supposed to invoke a `ManageHook` through `activateLogHook`
which consults a global `NetActivated` extensible state to tell if it's
being invoked from `ewmhDesktopsEventHook`. This seems convoluted to me.

A better design, in my opinion, is to invoke the `ManageHook` directly
from `ewmhDesktopsEventHook`, and we just need a way to configure the
hook. Luckily, we now have `X.U.ExtensibleConf` which makes this
straightforward. So we now have a `setEwmhActivateHook`, and the
activation hook defaults to focusing the window, undoing the breaking
change.

Fixes: xmonad#396
Related: xmonad#110
Related: xmonad#192
Related: xmonad#128
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 20, 2021
xmonad#192 introduced a breaking change:

  * `XMonad.Hooks.EwmhDesktops`

    `ewmh` function will use `logHook` for handling activated window. And now
    by default window activation will do nothing.

This breaking change can be avoided if we designed that a bit
differently. xmonad#192 changed `ewmhDesktopsEventHook` to invoke `logHook`
instead of focusing the window that requested activation and now
`logHook` is supposed to invoke a `ManageHook` through `activateLogHook`
which consults a global `NetActivated` extensible state to tell if it's
being invoked from `ewmhDesktopsEventHook`. This seems convoluted to me.

A better design, in my opinion, is to invoke the `ManageHook` directly
from `ewmhDesktopsEventHook`, and we just need a way to configure the
hook. Luckily, we now have `X.U.ExtensibleConf` which makes this
straightforward. So we now have a `setEwmhActivateHook`, and the
activation hook defaults to focusing the window, undoing the breaking
change.

Fixes: xmonad#396
Related: xmonad#110
Related: xmonad#192
Related: xmonad#128
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 20, 2021
These are useful when one blocks some _NET_ACTIVE_WINDOW requests but
still wants to somehow show that a window requested focus.

Related: xmonad#110
Related: xmonad#128
Related: xmonad#192
liskin added a commit to liskin/xmonad-contrib that referenced this pull request Oct 20, 2021
xmonad#192 introduced a breaking change:

  * `XMonad.Hooks.EwmhDesktops`

    `ewmh` function will use `logHook` for handling activated window. And now
    by default window activation will do nothing.

This breaking change can be avoided if we designed that a bit
differently. xmonad#192 changed `ewmhDesktopsEventHook` to invoke `logHook`
instead of focusing the window that requested activation and now
`logHook` is supposed to invoke a `ManageHook` through `activateLogHook`
which consults a global `NetActivated` extensible state to tell if it's
being invoked from `ewmhDesktopsEventHook`. This seems convoluted to me.

A better design, in my opinion, is to invoke the `ManageHook` directly
from `ewmhDesktopsEventHook`, and we just need a way to configure the
hook. Luckily, we now have `X.U.ExtensibleConf` which makes this
straightforward. So we now have a `setEwmhActivateHook`, and the
activation hook defaults to focusing the window, undoing the breaking
change.

Fixes: xmonad#396
Related: xmonad#110
Related: xmonad#192
Related: xmonad#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants