[x64] Add GFNI and AVX512VBMI optimization for VECTOR_SHL(int8)
#2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `{v}gf2p8mulb` as a general int8-multiplication instruction to simulate bit-shifts.
Wunkolo
force-pushed
the
gfni-shl-int8
branch
from
47357b3 to
179ee76
Compare
|
You probably have better chance of having this merged in the Canary repo: |
|
Ah I'd rather contribute here at xenia's core implementation and let it find its way downstream into canary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
{v}gf2p8mulbas a general int8-multiplication instruction to simulate bit-shifts.Verified the implementation with
instr__gen_vslbfrom #1348. Can be grabbed with: