Avoid having isShow as true after handleCancel action #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJkit
approved these changes
Jul 10, 2018
|
Sorry, @khrizt, something happened by the way, and this PR has been merged into the code base. I revert the "revert" process, so everything works just fine now. My apologies. |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the order of this calls avoids the fact that the isShow can be true after calling handleCancel.
I realized of this using this library on a react-native project, btw this library works with NativeRouter too, and using
Alert.alertto show the confirmation dialog to the user. The isShow prop and the original call order made it appear 2 times.