Skip to content

Demos #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 14, 2024
Merged

Demos #248

merged 7 commits into from
Jan 14, 2024

Conversation

Bricklou
Copy link
Contributor

@Bricklou Bricklou commented Jan 8, 2024 •
edited
Loading

Implemented editable voids as requested.
Close #72
Close #73

Please merge #246 first.

pubuzhixing8
pubuzhixing8 reviewed Jan 13, 2024
View reviewed changes
@pubuzhixing8
Copy link
Collaborator

Hi, @Bricklou
There is no problem with this PR overall, but there are some exceptions when running locally. You can try importing Range:
import { createEditor, NodeEntry, Text, Range } from 'slate';
Screen Shot 2024-01-13 at 11 36 27
In addition, there are some conflicts that need to be resolved

@pubuzhixing8 pubuzhixing8 merged commit 140a664 into worktile:master Jan 14, 2024
@Bricklou Bricklou deleted the demos branch January 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pubuzhixing8 pubuzhixing8 pubuzhixing8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeds demo Editable Voids demo
2 participants
@Bricklou @pubuzhixing8