-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Five improvements for ReaderDetailHeaderView #23909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23909-8e924e6 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8e924e6 | |
| App Center Build | WPiOS - One-Offs #11210 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23909-8e924e6 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8e924e6 | |
| App Center Build | jetpack-installable-builds #10248 |
crazytonyli
approved these changes
Dec 19, 2024
262531e to
60165f7
Compare
jkmassel
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Fix button like animation * Hide toolbar on scroll * Use CachedAsyncImage * Fix subscribe button position and header layout issues * Rename ReaderDetailHeaderView * Update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Changes
CachedAsyncImageinstead ofAsyncImageReaderDetailHeaderView(remove obsolete "New" component)To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: