Skip to content

Reader: Enhance cover image #23897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 17, 2024
Merged

Reader: Enhance cover image #23897

merged 11 commits into from
Dec 17, 2024

Conversation

@kean
Copy link
Contributor

@kean kean commented Dec 14, 2024 •
edited
Loading

This PR enhances the cover image behavior a little bit. Changes:

  • The app now defaults to the standard cover aspect ratio it expects – no more jumping
  • Move the "Reading Preferences" button (used rarely) to the "More" menu
  • Add a bit more spacing for post header (looks more pleasant with the cover)
  • Add a tiny bit more padding for posts in the feed too
  • Fix an issue with dark/light navigation items transition: before, after
  • Remove ImageLoader, CachedAnimatedImageView, and ImageDimensionsFetcher usages
  • Enhance AsyncImageView API
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-14.at.18.14.17.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Media label Dec 14, 2024
@kean kean added this to the Pending milestone Dec 14, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23897-8f9ce2d
Version25.6
Bundle IDorg.wordpress.alpha
Commit8f9ce2d
App Center BuildWPiOS - One-Offs #11196
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23897-8f9ce2d
Version25.6
Bundle IDcom.jetpack.alpha
Commit8f9ce2d
App Center Buildjetpack-installable-builds #10234
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Refactor: Remove ImageLoader from a few more places Reader: Enhance cover image Dec 14, 2024
@kean kean mentioned this pull request Dec 16, 2024
Closed
14 tasks
@kean kean requested a review from crazytonyli December 16, 2024 15:13
kean
kean commented Dec 16, 2024
View reviewed changes
WordPress/Classes/Utility/Media/AsyncImageView.swift
final class AsyncImageView: UIView {
let imageView = GIFImageView()

private let imageView = GIFImageView()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enhanced the API so that the implementation details (GIFImageView) don't leak and AsyncImageView has full control over the image. The image property will now also correctly support AnimagedImage, both setter and getter.

@kean kean modified the milestones: Pending, 25.6 ❄️ Dec 16, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 16, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean enabled auto-merge December 17, 2024 18:22
@kean kean added this pull request to the merge queue Dec 17, 2024
Merged via the queue into trunk with commit f035b18 Dec 17, 2024
25 checks passed
@kean kean deleted the task/remove-remaining-image-loader-usages branch December 17, 2024 19:17
@kean kean mentioned this pull request Dec 18, 2024
Closed
jkmassel pushed a commit that referenced this pull request Jan 16, 2025
@kean @jkmassel
Reader: Enhance cover image (#23897)
1880073 
* Replace DimensionFetcher usage

* Remove ImageLoader usage from ReaderDetailFeaturedImageView

* Remove ImageLoader from StatsLatestPostSummaryInsightsCell

* Remove ImageDimensionsFetcher usage

* Remove unused useCompatibilityMode

* Move reading preferences to the more menu

* Add a bit more spacing for posts in Reader

* Refine AsyncImageView API

* Fix dark/light transition on scroll

* Update release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees

No one assigned

Labels

Media

Projects

None yet

Milestone

25.6

Development

Successfully merging this pull request may close these issues.

5 participants

@kean @wpmobilebot @dangermattic @crazytonyli