[WIP] trying to reach feature parity with mpv scripts #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to run commands like bundle install if theres a syntax error in the codebase
100ms is way too high of a timeframe
mpv recently added new infrastructure to handle generic executable scripts. Instead of unix sockets it uses file descriptor inheritance. See: mpv-player/mpv@e2ab6b7
this stuff seems pointless if not worse. alive makes the methods fail silently.
This makes the code way easier to follow.
This allows the main thread to block until mpv has quit, allowing the event loop to continue pumping.
pigoz
force-pushed
the
master
branch
2 times, most recently
from
4fbfdc1 to
2a7cbbe
Compare
|
Thanks for hacking at this! Let me know when it's ready for review. |
previous code would run client-message/property-change on the event loop thread, generating a deadlock if the observer callback invoked another command.
I use the provided request_id mechanism provided by mpv's ipc interface. Sadly it's a bit more code than I'd like to, but it doesn't seem like it can be implemented in a shorter/simpler fashion.
I'm sure concurrent-ruby's authors are better at coding than me. I hate to add a dependency to an otherwise minimalistic gem, but it kinda felt wrong to NIH this kind of stuff, and anyway it's kind of Ruby's fault for not providing these utilities in the stdlib.
see previous commit for rationale
|
I should have backported everything from my original gem (while making it much nicer/robust). Next Sunday I will port my "user gem" to use this version of the library in order to dogfood it a little bit. Still unsure about the |
It can also be used in non test code as a synchronization mechanism, so this name makes a little more sense.
pigoz
force-pushed
the
master
branch
2 times, most recently
from
cc666d0 to
5f1b898
Compare
Since this is such a common operation that it is worth to make it more convenient by trading some safety. This was the original behavior before introducing the new event loop, so it only makes sense to add this programming style back.
|
I just realized that this has been sitting idle for a bit. Is there anything else it needs before I do some review @pigoz? |
|
Yes, sorry. My fault. I was not happy at all with the API for drawing to the OSD but my short attention span prevented me from coming up with something. I might actually remove from this PR so it can move forward. |
|
No problem at all! Just wanted to see if there was anything I could help with 🙂
Sent from mobile. Please excuse my brevity.
… On Sep 24, 2020, at 2:05 AM, Stefano Pigozzi ***@***.***> wrote:
Yes, sorry. My fault. I was not happy at all with the API for drawing to the OSD but my short attention span prevented me from coming up with something. I might actually remove from this PR so it can move forward.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've been working on https://github.com/pigoz/lat using this gem as a base to write a Ruby mpv script. I'm in the process of upstreaming the features I've added (key bindings, observers), automated tests, and simplifications to the event loop. I'm still figuring out an API to deal with generic events and one to wait for a certain event. The idea is to allow people to write mpv scripts in ruby instead of Lua / JavaScript.
The exciting part is mpv recently added a way to run any kind of executable script, so you can do stuff like
mpv --script=/path/to/ruby-script(See: mpv-player/mpv@e2ab6b7)It's not ready to merge yet. But I wanted to start collecting some feedback. If the breaking changes are too many, please say so :)